-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to interpolation to pressure levels #158
Conversation
…es with geopotential.
Everything should be ready for review now. Test passes and inference code runs on casper. |
I have increased confidence that the IFS postprocessing documentation is wrong about two things. Equation 3 has ps and pL flipped, as does equation 6. It also looks like the height-dependent temperature corrections are being used to extrapolate geopotential after all. My answers are now really close to those from ERA5 and are probably about as close as I can get without direct access to the FULL POS source code, which I am still working on getting. @jsschreck and @yingkaisha please look over because I want to get everything merged this afternoon. |
Thanks John! Merging now. |
I made some significant revisions to the pressure level interpolation module to accommodate the issues @yingkaisha 's PR raised and to make the pressure interpolation process for geopotential and temperature consistent with CESM/ECMWF. New features:
credit.interp.full_state_pressure_interpolation
as a numpy array rather than embedded in xarray Dataset with other state variables.