-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add concept to subset results in CDISC #313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcarlsenca
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's get this on dev and qa and we can more comprhensive check across a range of CDISC subsets (and non-CDISC examples)
bcarlsenca
added a commit
that referenced
this pull request
Feb 4, 2025
* mapset fixes * EVSRESTAPI-329: Using concept active flag instead of "Retired_Concept" status. (#240) * EVSRESTAPI-329: Using concept active flag instead of "Retired_Concept" status. * RDFBROWSER-390: Made history replacement code link to replacement concept * EVSRESTAPI-329: Fixed inactive conepts to show all sections if synonyms are present * RDFBROWSER-383: Angular 15 Upgrade * ability to display terminology in search results * add basic page for multi-search * set header for multisearch * Update version to 1.9.0 * RDFBROWSER-383: downgrade node version to build on dev * big refactor into button toggle * link to terminologies in list * checkbox buttons * cleaning up some things * disable multi-select search if no terms selected * search partially working * links work * tweaks + future support for saving terminologies * fixes * show currently selected terms in header * save previously used terms for new search * show terminology column in multi-search * Show map "group / rank" in the mappings table (#241) * Update to the HHS warning banner (#242) * couple feedback changes * change buttons to links * add separator bars * slight checkbox adjustments * bug on dev * requested tweaks * ncit/ncim at the top of the list * fix term links in multi-search * small fix for picklist * check licenses in multi-search * temp blocker for export with restricted terms * change terminology switch, fix code link in search * fix issues with direct linking * change sidebar ncim link * couple more sidebar changes * change image for multi-search * edits to the multiSearch image * Add node version switching stuff to README * bugfix * RDFBROWSER-370 * label change * put multi-term at the top * fix first term switch on welcome * remove hard restrictions from export * how did this get back in there? * EVSRESTAPI-382: Frontend should send a special header to the backend * fix label * basic source stats module * fix error * front end * bugfix * formatting for merge * EVSRESTAPI-382: license stuff (#248) * Fixes for ui-button-info->p-button-info, updates for Zuul to send ui license * Cleanup of buttons style * CLEANUP: fix small issue with sizing on search page * Fix new button * RDFBROWSER-404 * STYLE: move expand all on subsets down by search bar * finish 387 frontend * Rdfbrowser 403-6 (#251) * RDFBROWSER-403 * RDFBROWSER-403 * RDFBROWSER-405 * deal with dumb extra url stuff * Enable banner (#254) * RDFBROWSER-110: Update google analytics to G4 (#255) * Rdfbrowser 40 x (#256) * RDFBROWSER-403 * RDFBROWSER-403 * RDFBROWSER-405 * RDFBROWSER-400: UI support for linking codes * fixed bug in deselection after clicking home * no source links unless ncim right now * quick bug fix * RDFBROWSER-407 - Standardized loading spinner (#259) * RDFBROWSER-407 - Fixed mapping details spinner * sort ncit and ncim to the top of the term picklist (#260) * fix bug in mapping detail links * fix hierarchy switch (#261) * fix subset link not showing * fix table sorting in mapping/subsets (#262) * RDFBROWSER-435, RDFBROWSER-436: fixes for using synonym sources in search and opening SNOMED maps * RDFBROWSER-435: restore the terminology list mode for recovering multi terminology searches * Update versions to 1.10.0 (#266) * Update CHANGELOG.md for 1.9.0 * added ena external link map. Fixed deprecated async call (#270) * fix zero subset-member details display (#271) * Alg/rdfbrowser 443 upgrade java17 (#278) * Updated CDISC format (#274) * [RDFBROWSER-312] License decline/escape fix (#280) * [RDFBROWSER 427] help page update (#281) * testing branch protections * [RDFBROWSER-445] term form suggestion (#283) * Pva/rdfbrowser 439 444 bugfixing (#284) * RDFBROWSER-439 * RDFBROWSER-444 * Update CHANGELOG.md for 1.10 * Set date on CHANGELOG.md * Set version * RDFBROWSER-470: Addding missing terms in help page (#286) * RDFBROWSER-272: fix definition source * RDFBROWSER-477: fix issues with export - tested on NCIt, NCIm, MGED (#287) * Update CHANGELOG.md date to today * EVSRESTAPI-462 replaced hardcoded recaptcha site key with form prop. Added tests (#288) * RDFBROWSER-486: fix logic to allow nci maps to download properly (#289) * EVSRESTAPI-488 Updated how the submitted form is populated * EVSRESTAPI-488 fixing variables and adding comments * Set version * Bump ws and socket.io in /web/frontend (#292) * Updated the form to check for multiple select and implemented a filter option * fix mapping search export (#294) * forgot term * fix paging bug * small fix --------- Co-authored-by: Alicia G <[email protected]> * RDFBROWSER-479 implemented success/fail message when form is submitted. Updated code structure * Removed unnecessary css for p-multiselect and hid filter icon * RDFBROWSER-450 Added a timeout for changing between forms to show the loader * RDFBROWSER-450 Added an additional timeout with an await for an even smoother transition * front end changes + .gitignore (#298) * Pva/rdfbrowser 490 show map rule (#299) * add toggle for rules in mapping page * only show rule button for snomed * add security scanning (#301) * add security scanning * Small change to go to web directory to run the gradlew command --------- Co-authored-by: Brian Carlsen <[email protected]> * Pva/rdfbrowser 493 update libraries frontend (#305) * update libraries * history is a reserved word in excel. who knew! * Update logback libraries * RDFBROWSER-492: handle "extra" values in CDISC subset view (#306) * RDFBROWSER-494 - Trivy github action (#309) * first try * change branch name * split jobs * fix attempt * debugs not needed anymore, caching not working * trying caching again * see if it worked * didn't work * forgot to switch out this one * high and critical vuln, list out found vulns if any * partial fix to subset display (#311) * add banner to front end (#312) * add concept to subset results in CDISC (#313) * add concept to subset results in CDISC * attempt to fix db download fail * attempt to fix db download fail * trying some bugfixes here * error checking for synonymSources * link not in description * try fixing again * update cross-spawn * audit fix and cross-spawn update part 2 * one more try * fix vulnerability * equality change * fix 503 and some of 504 * fix for MRCT maybe, CDISC synonym in top row * partial export fix for CDISC * small fix to export first row formatting * some more feedback fixes * wrong CDISC codelist names * fix export * fixes to exports + more codelist names * fix deprecation warning frontend * fix deprecation warning backend * RDF-509: NCI PT default for codelist name * RDFBROWSER-505: explicit entry for client sdk project (#316) * RDFRBROWSER-510: Add a comment to clarify differences between table and the link (#317) * Add a comment to clarify differences between table and the link * formatting changes * some feedback * reworking based on summary * don't mess with concepts in subsets * some changes for concepts * changes with Brian * small fix * error checking * another error check * error message clarify * add form and fix links * fix export * small formatting * change source checking in grouper * Alg/rdfbrowser 497 popout hierarchy window (#320) * Added popout basic feature * RDFBROWSER-497 implemented load all button, added display count, added popout component * RDFBROWSER-497 reworked design, popout window added * RDFBROWSER-497 implemented popout functionality * Updated some code for additionaly functionality * RDFBROWSER-497 fixed tree position display, moved load all to a link * RDFBROWSER-497 reworked popout to follow security protocols. Implemented redirect with popin action * RDFBROWSER-497 Fixed issue with highlighting, renamed classes to popup * RDFBROWSER-497 made configService protected, updated cross-spawn version for trivvy * RDFBROWSER-505: explicit entry for client sdk project (#316) * RDFRBROWSER-510: Add a comment to clarify differences between table and the link (#317) * Add a comment to clarify differences between table and the link * formatting changes * some feedback * reworking based on summary * don't mess with concepts in subsets * some changes for concepts * changes with Brian * small fix * error checking * another error check * error message clarify * add form and fix links * RDFBROWSER-497 hid footer on popup display. Updated npm version * Trying npm version 10.9.1 for trivy failure * RDFBROWSER-497 added baseHref to popup window url tree * RDFBROWSER-497 addressing pr feedback. --------- Co-authored-by: Alicia Garcia <[email protected]> Co-authored-by: Brian Carlsen <[email protected]> Co-authored-by: peter-va <[email protected]> * Another round of review and cleanup * RDRBROWSER-518 Added new tile link and img for report exporter (#321) * Add robots.txt matching nci terms browsers * small export fixes * add changes for grouper subsets * Alg/rdfbrowser 515 term form accept code param (#322) * RDRBROWSER-518 Added new tile link and img for report exporter * RDFBROWSER-515 added code param for term form, fixed routing for Term Suggestion button in concept-display * RDFBROWSER-525: fix issues with popout hierarchy (#325) * RDFBROWSER-528: move dot inside closing paragraph tag * RDFBROWSER-527: excel sheets are not allowed to have a tab called 'History', use 'Concept History' * RDFBROWSER-533, RDFBROWSER-534: Fixes for paging subsets with a sort and withdraw </p>. fix * Add releasetag to makefile * CLEANUP: remove some logging --------- Co-authored-by: peter-va <[email protected]> Co-authored-by: twkatadin <[email protected]> Co-authored-by: Peter Van Ausdeln <[email protected]> Co-authored-by: twkatadin <[email protected]> Co-authored-by: Alicia G <[email protected]> Co-authored-by: Alicia G. <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alicia Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add subset concept to display of CDISC subset details: https://tracker.nci.nih.gov/browse/RDFBROWSER-501