Pva/rdfbrowser 540 npm evs explore build process #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcarlsenca
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Lots of changes, but mostly file renaming. There are two more things:
- Work on the top level README so that it properly explains how to build and run the project. Right now we have "Building the Java Webapp" and "Launching EVS-EXPLORE for development" sections (which are probably wrong). We should also have a "Making a tag for deployment" where we talk about the staged process - build the fronend, build the web, commit changes then make a tag.
- Make sure to test that "make run" still works from the makefile.
…thub.com:NCIEVS/evs-explore into pva/RDFBROWSER-540-npm-evs-explore-build-process
peter-va
deleted the
pva/RDFBROWSER-540-npm-evs-explore-build-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.nci.nih.gov/browse/RDFBROWSER-540 update npm and build process