Pva/evsrestapi 538 add error tracking audits #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcarlsenca
reviewed
Feb 7, 2025
| if (e instanceof ResponseStatusException) { | ||
| throw e; | ||
| } | ||
|
|
||
| logger.error("Unexpected error", e); | ||
| String functionName = | ||
| StackWalker.getInstance().walk(s -> s.skip(1).findFirst()).get().getMethodName(); | ||
| final Terminology term = termUtils.getIndexedTerminology(terminology, elasticQueryService); |
There was a problem hiding this comment.
I would back off of this. Just using the terminology string is probably good here. If we've had an error, then trying to do these lookups might themselves fail. All we really want to do is get the best info we have into the index as soon as possible. So don't inject termUtils or the elasticQueryService. Like let's start simple and work up to this if we need it at some point.
bcarlsenca
reviewed
Feb 8, 2025
src/main/java/gov/nih/nci/evs/api/controller/BaseController.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nih/nci/evs/api/service/AbstractStardogLoadServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nih/nci/evs/api/service/AbstractStardogLoadServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nih/nci/evs/api/service/BaseLoaderService.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nih/nci/evs/api/service/LoaderServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nih/nci/evs/api/service/SparqlQueryManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nih/nci/evs/api/service/SparqlQueryManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nih/nci/evs/api/service/SparqlQueryManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nih/nci/evs/api/service/SparqlQueryManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
bcarlsenca
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVSRESTAPI-538: Add error tracking audits
https://tracker.nci.nih.gov/browse/EVSRESTAPI-538
draft for now to more easily review code changes