Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the toyFF and add tests #70

Merged
merged 5 commits into from
Jun 19, 2024
Merged

fix the toyFF and add tests #70

merged 5 commits into from
Jun 19, 2024

Conversation

t7phy
Copy link
Member

@t7phy t7phy commented Jun 18, 2024

This fixes the ToyFF and also adds a unit test for it.

@t7phy t7phy requested a review from felixhekhorn June 18, 2024 13:49
@felixhekhorn felixhekhorn added the bug Something isn't working label Jun 19, 2024
@felixhekhorn
Copy link
Contributor

@t7phy

  • don't use assert with float numbers (a simple search will remind you why) - and a round does not help, because you do not know the representation it will cast to
  • the solution for poetry was spelled out plainly

@felixhekhorn felixhekhorn merged commit 42dcb7f into main Jun 19, 2024
6 checks passed
@felixhekhorn felixhekhorn deleted the toyff_fix branch June 19, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixhekhorn felixhekhorn felixhekhorn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t7phy @felixhekhorn