update logic to identify MSU machine (#1497) #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Execute the g-w compute node build option using the updated |
|
@DavidNew-NOAA and @DavidHuber-NOAA : If either of you have time, can you quickly review the changes in this PR? The changes are straightforward. The GDASApp |
DavidHuber-NOAA
approved these changes
Feb 13, 2025
|
Thank you @DavidHuber-NOAA . You already fixed this problem in g-w. GDASApp is just catching up now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic in
ush/detect.shdoes not properly identify the MSU machine being used (Hercules or Orion) when the script is run on compute nodes. This PR incorporates logic from the g-wdetect_machine.shto fix this problem.Companion PRs
None
Issues
Resolves #1497
Automated CI tests to run in Global Workflow