Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature/gdas-validation with develop #686

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Jan 18, 2024

Description
feature/gdas-validation is behind develop. This PR brings feature/gdas-validation up to date with develop

Resolves #685

Type of change

  • Maintenance

How Has This Been Tested?
Install develop and forked feature/gdas-validation and run GSI ctests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing tests pass with my changes

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jan 18, 2024
@RussTreadon-NOAA RussTreadon-NOAA linked an issue Jan 18, 2024 that may be closed by this pull request
@RussTreadon-NOAA
Copy link
Contributor Author

@emilyhcliu , @ADCollard , and @CoryMartin-NOAA : Is this PR necessary? Are developers still using NOAA-EMC/GSI:feature/gdas-validation

@CoryMartin-NOAA
Copy link
Contributor

I do think we need this branch, as there are some CRTM version changes (among others) to make the validation consistent

@RussTreadon-NOAA
Copy link
Contributor Author

I do think we need this branch, as there are some CRTM version changes (among others) to make the validation consistent

I agree. We'll need to monitor commits to develop and decide if/when to merge updates into feature/gdas-validation.

@RussTreadon-NOAA
Copy link
Contributor Author

Since this is a merge of approved changes from develop into a feature branch go ahead and squash merge changes in this PR into feature/gdas-validation.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 88aaac7 into NOAA-EMC:feature/gdas-validation Jan 18, 2024
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/gdas-validation branch February 20, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update feature/gdas-validation with develop
4 participants