A draft PR with non-functional changes to make ctests pass #827
Conversation
…age when compiling
|
@TingLei-daprediction , GSI issues require an issue. Which issue(s) are associated with the draft PR? |
|
Russ , I will open an issue when I come back to the office next Monday .
Thanks
Ting
…On Thu, Jan 30, 2025 at 8:29 AM RussTreadon-NOAA ***@***.***> wrote:
@TingLei-daprediction <https://github.com/TingLei-daprediction> , GSI
issues require an issue. Which issue(s) are associated with the draft PR?
—
Reply to this email directly, view it on GitHub
<#827 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADSYWFZL2M2VYM46TE2BPN32NISMXAVCNFSM6AAAAABWAVACJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRUGUZDCMZSG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This PR is into a release branch of RRFS. Release branches should (per git flow) come from develop. Are all of these changes in develop of GSI? |
|
Cory, GDIT's optimization will only be used in RRFS as discussed with Russ last year. The modification will create two new "fix" files. The fix files will change with background grid configurations. It is not portable for GSI applications. However, since run time is really important for RRFS NA domain. RRFS project decided to use this function for implementation. So we will merge this to the existing release branch. |
|
ok thanks @ShunLiu-NOAA for the clarification |
|
FYI: gitub CI fails for |
|
An update on this draft PR and draft PR 826 |
This PR contains non-functional changes (compiling options/lib , openmp directives) to @ShunLiu-NOAA 's PR (#811), except for a c++ function to call zlib be replaced by a self-contained function.
This PR with the optimization changes would pass ctests with the release/rrfs.1.0.0 (the target branch) with the same nonfunctional changes ( #826).
These draft PR are for evaluation/discussion of RRFS GSI developer to decide the efficient way to incorporate the optimization function in the above PR 811.