Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Data directory to data for fv3jedi test case #281

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

SamuelDegelia-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA commented Feb 14, 2025

Description

This PR is partly addresses #273. I have a PR ready to address that issue but it has become a bit large. Thus, I am choosing to split it up.

Here we rename Data/obs for fv3jedi to data/obs (now matching the mpasjedi test case). This change does not change any results.

Reasoning: in order to automatically build the ctests using the yamls in rrfs-test/validated_yamls/templates/obtype_config, it would be helpful to have the same directory structure between our fv3jedi and mpasjedi test cases. This is because the radiance yamls refer to static bias correction files located under data/obs. Keeping the same directory structure allows us to more easily use the same obtype_config yamls for both test cases.

Issue(s) addressed

#273 in part

Dependencies (if applicable)

None

Checklist

  • I have performed a self-review of my own code.
  • I have run rrfs tests before creating the PR (if applicable).

@SamuelDegelia-NOAA
Copy link
Contributor Author

SamuelDegelia-NOAA commented Feb 14, 2025

Ctest on Hera confirming that these changes do not affect any results:

[Samuel.Degelia@hfe05 rrfs-test]$ ctest -j8
Test project /scratch2/BMC/zrtrr/Samuel.Degelia/RDASApp_changedata/RDASApp/build/rrfs-test
    Start 2: rrfs_fv3jedi_2024052700_getkf_observer
    Start 5: rrfs_mpasjedi_2024052700_getkf_observer
    Start 1: rrfs_fv3jedi_2024052700_Ens3Dvar
    Start 4: rrfs_mpasjedi_2024052700_Ens3Dvar
    Start 7: rrfs_mpasjedi_2024052700_bumploc
    Start 8: rrfs_bufr2ioda_msonet
1/8 Test #8: rrfs_bufr2ioda_msonet .....................   Passed   27.16 sec
2/8 Test #2: rrfs_fv3jedi_2024052700_getkf_observer ....   Passed  138.68 sec
    Start 3: rrfs_fv3jedi_2024052700_getkf_solver
3/8 Test #5: rrfs_mpasjedi_2024052700_getkf_observer ...   Passed  149.72 sec
    Start 6: rrfs_mpasjedi_2024052700_getkf_solver
4/8 Test #1: rrfs_fv3jedi_2024052700_Ens3Dvar ..........   Passed  287.94 sec
5/8 Test #7: rrfs_mpasjedi_2024052700_bumploc ..........   Passed  324.41 sec
6/8 Test #4: rrfs_mpasjedi_2024052700_Ens3Dvar .........   Passed  327.06 sec
7/8 Test #3: rrfs_fv3jedi_2024052700_getkf_solver ......   Passed  210.96 sec
8/8 Test #6: rrfs_mpasjedi_2024052700_getkf_solver .....   Passed  242.88 sec

100% tests passed, 0 tests failed out of 8

Label Time Summary:
mpi            = 1708.81 sec*proc (8 tests)
rdas-bundle    = 1708.81 sec*proc (8 tests)
script         = 1708.81 sec*proc (8 tests)

Total Test time (real) = 392.87 sec

Copy link
Collaborator

@delippi delippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. This has bothered me for awhile, but I've managed with my own workarounds. Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants