revisions to snowfall melting and accumulation from @tanyasmirnova #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
tanyasmirnova
approved these changes
Dec 18, 2023
SamuelTrahanNOAA
changed the title
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Dec 19, 2023
jkbk2004
pushed a commit
that referenced
this pull request
Dec 21, 2023
* pressure is not density * wrong variable sent for snodi * explain lakedepth corruption safeguards * module_sf_ruclsm.f90: explain the snow_mosaic=0 line * add flag to track new freezing lake ice grids * change name of lake_freeze to flag_lakefreeze --------- Co-authored-by: Jili Dong <[email protected]>
zach1221
pushed a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
Dec 21, 2023
…nodi + #2047, #2053, and #2056 (#2044) FV3 diagnostic fixes, CCPP fixes for model crashes, new PR template - UFS: - commit message in PR template (#2053) - fix hercules crashes (#2015) - CMEPS & FV3: Bad data from in CCPP CLM Lake physics scheme caused model crashes - Communicate changes to lake ice (Closes #2055, NOAA-EMC/CMEPS#105, NOAA-EMC/fv3atm#741) - unit mismatch (NOAA-EMC/fv3atm#736) - FV3: correct errors in diagnostic calculations - snodi had weasdi data in it (NOAA-EMC/fv3atm#736) - revisions to RUC LSM snowfall melting and accumulation (NOAA-EMC/fv3atm#739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an urgent minor change to RUC LSM from @tanyasmirnova.
This includes:
Issue(s) addressed
All issues are in ccpp-physics:
Testing
How were these changes tested?
Manual testing by @tanyasmirnova on a test case.
Hera regression tests.
What compilers / HPCs was it tested with?
Hera intel.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Existing regression tests are sufficient.
Have the ufs-weather-model regression test been run? On what platform?
Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
Yes. Configurations that use RUC LSM will change.
Please commit the regression test log files in your ufs-weather-model branch
Done.
Dependencies