Add gfs cycles to C48mx500_3DVarAOWCDA

[AntonMFernando-NOAA]

Description

The test C48mx500_3DVarAOWCDA will be updated to test more features. - update interval: 0 -> 6.

Resolves #2563

Type of change

• Bug fix (fixes something broken)
• New feature (adds functionality)
• Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO
• Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)
  • EMC verif-global
  • GDAS
  • GFS-utils
  • GSI
  • GSI-monitor
  • GSI-utils
  • UFS-utils
  • UFS-weather-model
  • wxflow

How has this been tested?

C48mx500_3DVarAOWCDA.yaml test on HERA

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have documented my code, including function, input, and output descriptions
• My changes generate no new warnings
• New and existing tests pass with my changes
• This change is covered by an existing CI test or a new one has been added
• Any new scripts have been added to the .github/CODEOWNERS file with owners
• I have made corresponding changes to the system documentation if necessary

[JessicaMeixner-NOAA]

I think we could also turn on waves for this! Just APP=S2S -> S2SW. ICs should be there. I didn't turn it on because there was no point w/out the gfs part.

[JessicaMeixner-NOAA]

This looks great to me assuming it runs out of the box now!

Tagging @guillaumevernieres so at minimum he's aware S2SW got turned on as we should probably add it in some test like this, but if he'd prefer a different one we can do that instead.

[AntonMFernando-NOAA]

@JessicaMeixner-NOAA @WalterKolczynski-NOAA Ran a test on HERA with the current branch and failed. The reason is some history files are missing.
Test is at: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_cyc1

[JessicaMeixner-NOAA]

@JessicaMeixner-NOAA @WalterKolczynski-NOAA Ran a test on HERA with the current branch and failed. The reason is some history files are missing. Test is at: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_cyc1

Where are your log files?

[AntonMFernando-NOAA]

@JessicaMeixner-NOAA @WalterKolczynski-NOAA Ran a test on HERA with the current branch and failed. The reason is some history files are missing. Test is at: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_cyc1

Where are your log files?

@JessicaMeixner-NOAA /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/COMROOT/gfs_cyc1/logs/2021032500

[WalterKolczynski-NOAA]

@AntonMFernando-NOAA Something is wrong with the FHMAX_WAV being used by rocoto. You shouldn't have gdas wave post jobs beyond 9 hours.

[JessicaMeixner-NOAA]

I fixed that bug I thought... let me see if a change didn't make it into the PR...

[JessicaMeixner-NOAA]

This was my fix: JessicaMeixner-NOAA@b1d31ca

And this was my output:
/scratch1/NCEPDEV/climate/Jessica.Meixner/WaveUpdatesHR5/cyclewwavet03/EXPDIR
/scratch1/NCEPDEV/climate/Jessica.Meixner/WaveUpdatesHR5/cyclewwavet03/COMROOT/

should be similar to your run but I had to use my own staged output, and it's a little out of date at this point. @WalterKolczynski-NOAA is right, we just need the max number of jobs to be correct. Not sure why it's not getting the correct fhmax_wav now.

[JessicaMeixner-NOAA]

@AntonMFernando-NOAA :

This line https://github.com/NOAA-EMC/global-workflow/blob/develop/workflow/rocoto/gfs_tasks.py#L1206

Needs to go from:
fhrs = self._get_forecast_hours('gfs', self._configs['wavepostsbs'], 'wave')

to:

fhrs = self._get_forecast_hours(self.run, self._configs['wavepostsbs'], 'wave')

[AntonMFernando-NOAA]

@JessicaMeixner-NOAA Running a new test. Let you know when it's done. Thanks!

[AntonMFernando-NOAA]

@JessicaMeixner-NOAA @WalterKolczynski-NOAA C48mx500_3DVarAOWCDA Test passed. Find the test on hera at: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_cyc3

[JessicaMeixner-NOAA]

Thanks for finding/fixing the wave issues to get waves turned on in this test!

[AntonMFernando-NOAA]

@WalterKolczynski-NOAA @JessicaMeixner-NOAA Spoke too soon. metpg2o1 job failed (last job) in gfs_cyc3. Error says,
metpg2o1 job failed [3:54](https://noaa-emc.slack.com/archives/D07ME3P64RM/p1738011259557259) ** ERROR: /scratch1/NCEPDEV/stmp2/Anton.Fernando/RUNDIRS/gfs_cyc3/gfs.2021032500/metpg2o1.2190777/grid2obs_step1/metplus_output/gather_by_VSDB/stat_analysis/upper_air/gfs_cyc3/gfs_cyc3_2021032500_2021032518_00.stat was not generated or zero size. But I don't think it's related to this PR.

[emcbot]

CI Passed on Hera in Build# 3
Built and ran in directory /scratch1/NCEPDEV/global/CI/3249

Experiment C48_ATM_bbcfc4cb Completed 1 Cycles: *SUCCESS* at Tue Jan 28 19:21:31 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_bbcfc4cb Completed 1 Cycles: *SUCCESS* at Tue Jan 28 19:27:56 UTC 2025
Experiment C48mx500_hybAOWCDA_bbcfc4cb Completed 2 Cycles: *SUCCESS* at Tue Jan 28 19:40:13 UTC 2025
Experiment C96C48_hybatmDA_bbcfc4cb Completed 3 Cycles: *SUCCESS* at Tue Jan 28 20:28:58 UTC 2025
Experiment C96_atm3DVar_bbcfc4cb Completed 3 Cycles: *SUCCESS* at Tue Jan 28 20:53:13 UTC 2025
Experiment C96C48_hybatmaerosnowDA_bbcfc4cb Completed 3 Cycles: *SUCCESS* at Tue Jan 28 20:53:14 UTC 2025
Experiment C48_S2SW_bbcfc4cb Completed 1 Cycles: *SUCCESS* at Tue Jan 28 21:11:25 UTC 2025
Experiment C48_S2SWA_gefs_bbcfc4cb Completed 1 Cycles: *SUCCESS* at Tue Jan 28 21:36:27 UTC 2025
Experiment C96C48_ufs_hybatmDA_bbcfc4cb Completed 3 Cycles: *SUCCESS* at Tue Jan 28 21:42:10 UTC 2025
Experiment C48mx500_3DVarAOWCDA_bbcfc4cb Completed 2 Cycles: *SUCCESS* at Tue Jan 28 22:00:25 UTC 2025