Skip to content

Add gfs cycles to C48mx500_3DVarAOWCDA #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 28, 2025
Merged

Add gfs cycles to C48mx500_3DVarAOWCDA #3249

merged 13 commits into from
Jan 28, 2025

Conversation

AntonMFernando-NOAA
Copy link
Contributor

@AntonMFernando-NOAA AntonMFernando-NOAA commented Jan 23, 2025 •
edited
Loading

Description

The test C48mx500_3DVarAOWCDA will be updated to test more features. - update interval: 0 -> 6.

Resolves #2563

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

C48mx500_3DVarAOWCDA.yaml test on HERA

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@JessicaMeixner-NOAA
Copy link
Contributor

I think we could also turn on waves for this! Just APP=S2S -> S2SW. ICs should be there. I didn't turn it on because there was no point w/out the gfs part.

JessicaMeixner-NOAA
JessicaMeixner-NOAA previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me assuming it runs out of the box now!

Tagging @guillaumevernieres so at minimum he's aware S2SW got turned on as we should probably add it in some test like this, but if he'd prefer a different one we can do that instead.

@AntonMFernando-NOAA AntonMFernando-NOAA marked this pull request as ready for review January 23, 2025 15:58
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Jan 24, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Jan 24, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera label Jan 27, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Jan 27, 2025
@AntonMFernando-NOAA
Copy link
Contributor Author

@JessicaMeixner-NOAA @WalterKolczynski-NOAA Ran a test on HERA with the current branch and failed. The reason is some history files are missing.
Test is at: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_cyc1

@JessicaMeixner-NOAA
Copy link
Contributor

@JessicaMeixner-NOAA @WalterKolczynski-NOAA Ran a test on HERA with the current branch and failed. The reason is some history files are missing. Test is at: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_cyc1

Where are your log files?

@AntonMFernando-NOAA
Copy link
Contributor Author

AntonMFernando-NOAA commented Jan 27, 2025 •
edited
Loading

@JessicaMeixner-NOAA @WalterKolczynski-NOAA Ran a test on HERA with the current branch and failed. The reason is some history files are missing. Test is at: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_cyc1

Where are your log files?

@JessicaMeixner-NOAA /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/COMROOT/gfs_cyc1/logs/2021032500

@WalterKolczynski-NOAA
Copy link
Contributor

@AntonMFernando-NOAA Something is wrong with the FHMAX_WAV being used by rocoto. You shouldn't have gdas wave post jobs beyond 9 hours.

@JessicaMeixner-NOAA
Copy link
Contributor

I fixed that bug I thought... let me see if a change didn't make it into the PR...

@JessicaMeixner-NOAA
Copy link
Contributor

This was my fix: JessicaMeixner-NOAA@b1d31ca

And this was my output:
/scratch1/NCEPDEV/climate/Jessica.Meixner/WaveUpdatesHR5/cyclewwavet03/EXPDIR
/scratch1/NCEPDEV/climate/Jessica.Meixner/WaveUpdatesHR5/cyclewwavet03/COMROOT/

should be similar to your run but I had to use my own staged output, and it's a little out of date at this point. @WalterKolczynski-NOAA is right, we just need the max number of jobs to be correct. Not sure why it's not getting the correct fhmax_wav now.

@JessicaMeixner-NOAA
Copy link
Contributor

@AntonMFernando-NOAA :

This line https://github.com/NOAA-EMC/global-workflow/blob/develop/workflow/rocoto/gfs_tasks.py#L1206

Needs to go from:
fhrs = self._get_forecast_hours('gfs', self._configs['wavepostsbs'], 'wave')

to:

fhrs = self._get_forecast_hours(self.run, self._configs['wavepostsbs'], 'wave')

@AntonMFernando-NOAA
Copy link
Contributor Author

@JessicaMeixner-NOAA Running a new test. Let you know when it's done. Thanks!

@AntonMFernando-NOAA
Copy link
Contributor Author

AntonMFernando-NOAA commented Jan 27, 2025 •
edited
Loading

@JessicaMeixner-NOAA @WalterKolczynski-NOAA C48mx500_3DVarAOWCDA Test passed. Find the test on hera at: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_cyc3

JessicaMeixner-NOAA
JessicaMeixner-NOAA previously approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding/fixing the wave issues to get waves turned on in this test!

@AntonMFernando-NOAA
Copy link
Contributor Author

AntonMFernando-NOAA commented Jan 27, 2025 •
edited
Loading

@WalterKolczynski-NOAA @JessicaMeixner-NOAA Spoke too soon. metpg2o1 job failed (last job) in gfs_cyc3. Error says,
metpg2o1 job failed [3:54](https://noaa-emc.slack.com/archives/D07ME3P64RM/p1738011259557259) ** ERROR: /scratch1/NCEPDEV/stmp2/Anton.Fernando/RUNDIRS/gfs_cyc3/gfs.2021032500/metpg2o1.2190777/grid2obs_step1/metplus_output/gather_by_VSDB/stat_analysis/upper_air/gfs_cyc3/gfs_cyc3_2021032500_2021032518_00.stat was not generated or zero size. But I don't think it's related to this PR.

@AntonMFernando-NOAA AntonMFernando-NOAA force-pushed the feature/add_gfs_cyc branch 3 times, most recently from 01e0048 to 75bafa8 Compare January 27, 2025 22:10
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Jan 28, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 28, 2025
@emcbot
Copy link

emcbot commented Jan 28, 2025

CI Passed on Hera in Build# 3
Built and ran in directory /scratch1/NCEPDEV/global/CI/3249


Experiment C48_ATM_bbcfc4cb Completed 1 Cycles: *SUCCESS* at Tue Jan 28 19:21:31 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_bbcfc4cb Completed 1 Cycles: *SUCCESS* at Tue Jan 28 19:27:56 UTC 2025
Experiment C48mx500_hybAOWCDA_bbcfc4cb Completed 2 Cycles: *SUCCESS* at Tue Jan 28 19:40:13 UTC 2025
Experiment C96C48_hybatmDA_bbcfc4cb Completed 3 Cycles: *SUCCESS* at Tue Jan 28 20:28:58 UTC 2025
Experiment C96_atm3DVar_bbcfc4cb Completed 3 Cycles: *SUCCESS* at Tue Jan 28 20:53:13 UTC 2025
Experiment C96C48_hybatmaerosnowDA_bbcfc4cb Completed 3 Cycles: *SUCCESS* at Tue Jan 28 20:53:14 UTC 2025
Experiment C48_S2SW_bbcfc4cb Completed 1 Cycles: *SUCCESS* at Tue Jan 28 21:11:25 UTC 2025
Experiment C48_S2SWA_gefs_bbcfc4cb Completed 1 Cycles: *SUCCESS* at Tue Jan 28 21:36:27 UTC 2025
Experiment C96C48_ufs_hybatmDA_bbcfc4cb Completed 3 Cycles: *SUCCESS* at Tue Jan 28 21:42:10 UTC 2025
Experiment C48mx500_3DVarAOWCDA_bbcfc4cb Completed 2 Cycles: *SUCCESS* at Tue Jan 28 22:00:25 UTC 2025

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit a783f9b into NOAA-EMC:develop Jan 28, 2025
10 of 11 checks passed
This was referenced Jan 29, 2025
Closed
Merged
Merged
tsga added a commit to tsga/global-workflow that referenced this pull request May 1, 2025
@tsga
Merge branch 'develop' into feature/land_iau
ad208da 
* develop:
  Update GSI hash and GSI fix version to resolve bugs (NOAA-EMC#3626)
  Add missing marine DA files to archiving  (NOAA-EMC#3596)
  Add a low resolution test to mimic GFSv17 cycling as much as possible (NOAA-EMC#3617)
  Add the setting to use the reject list for station t/q observations in GSI based soil DA (NOAA-EMC#3599)
  GitLab CI Framework for schedule PR cases and ctests on multi hosts (NOAA-EMC#3603)
  Avoid parallel restart I/O on WCOSS2 (NOAA-EMC#3615)
  Enables user toggling of GDASApp g-w ctests (NOAA-EMC#3587)
  COM variable updates for prep and some external downstream jobs (NOAA-EMC#3608)
  Remove MOS from system (NOAA-EMC#3612)
  Updates to enable soil DA  (NOAA-EMC#3452)
  Unexport SHELLOPTS when running htar (NOAA-EMC#3601)
  Fix check for netcdf wave restart (NOAA-EMC#3594)
  Call err_chk/err_exit for fatal errors in post JJobs/ex-scripts (NOAA-EMC#3571)
  Remove support for Jet and S4 (NOAA-EMC#3572)
  Hotfix in GitLab pipline for Nightly (env MACHINE breaks build on head node) (NOAA-EMC#3578)
  [hotfix] Missed a path during merging develop (NOAA-EMC#3577)
  Prepare for ops readiness - part 1 (NOAA-EMC#3557)
  Update UFS weather-model to 20250328 hash (NOAA-EMC#3528)
  Fix SFS fcst config (NOAA-EMC#3574)
  Use err_chk in GDAS j-jobs (NOAA-EMC#3570)
  Perform compute builds on Gaea head nodes (NOAA-EMC#3560)
  Add initial capability to produce JEDI-based observation space summary stat files (NOAA-EMC#3471)
  Spread epos over more nodes on Hera to increase allocated memory (NOAA-EMC#3567)
  Create separate gists when multiple files are published on GitHub (NOAA-EMC#3551)
  Use err_chk in GSI J-Jobs and scripts (NOAA-EMC#3549)
  Add unified jinja obs list to marine DA (NOAA-EMC#3530)
  Save snow and aerosol analysis increments (and logs and YAMLs) every cycle (NOAA-EMC#3537)
  Add Dependencies to SFS Cleanup Job (NOAA-EMC#3559)
  Updates archiving to reflect current naming of marine anl output (NOAA-EMC#3541)
  Temporarily disable compute builds on C6 (NOAA-EMC#3558)
  Update gdas.cd hash to resolve msu prod_util failure (NOAA-EMC#3556)
  COMIN/COMOUT updates for enkf chgres and downstream product jobs (NOAA-EMC#3518)
  Call err_chk in forecast scripts for fatal errors (NOAA-EMC#3515)
  Add Rocoto Jobs for the Missing Products of GEFS (NOAA-EMC#3466)
  Download subset fix data with python script (NOAA-EMC#3400)
  Check that partition should be set (NOAA-EMC#3543)
  Rename wave output and refactor some wave scripts to use MPMD, and fix some bugzillas along the way (NOAA-EMC#3517)
  Add support for dual batch partitions on AWS NOAA-EMC#3483
  Update CI build and run directories for GitLab Nightlies on C6 and added GitLab support on Hera (NOAA-EMC#3536)
  Hotfix path for CI in Jenkins on Gaea C6 to it's world-share path (NOAA-EMC#3532)
  Create single ocean grib2 product file (NOAA-EMC#3529)
  Scheduled Nightly CI/CD Pipeline Script in GitLab on Gaea C6 (NOAA-EMC#3493)
  make sure cold starts are handled correctly when DOIAU=YES (issue NOAA-EMC#3516) (NOAA-EMC#3520)
  Add check for DO_AERO_FCST before copying fv_tracer files (NOAA-EMC#3485)
  Use jinja templates instead of `@VARNAME@` in config files (NOAA-EMC#3411)
  Replace "status" (or comparable) with "err" in preparation for moving to err_chk/err_exit (NOAA-EMC#3507)
  Error in Java launch script for CI (NOAA-EMC#3465)
  Delete DATAROOT when running generate_workflows.sh (NOAA-EMC#3504)
  Fix 3244 garbled change (NOAA-EMC#3492)
  Enable ensemble archiving via Globus (NOAA-EMC#3479)
  Update MSU FIX_DIR paths (NOAA-EMC#3488)
  Updates for AOWCDA and hybatmaerosnowDA cases on Gaea C6 (NOAA-EMC#3487)
  Update GOCART path for GDAS/GFS/GCAFS implementations  (NOAA-EMC#3455)
  Make RUN Variables Explicit in `config.resources` (NOAA-EMC#3478)
  Remove unused key from enkfgdas_earc_vrfy (NOAA-EMC#3473)
  Bug fix to the failing early cycle marine DA ensemble re-centering (NOAA-EMC#3454)
  Make marine LETKF optional (NOAA-EMC#3462)
  When sourcing for RUN=enkf*, use CASE_ENS (NOAA-EMC#3475)
  Updates for Gaea: verif-global tag, tracker tag, Fit2Obs tag, and C768 analysis resources (NOAA-EMC#3463)
  Update gefswave glo_025 mesh file with new mask (NOAA-EMC#3457)
  Update MSU glopara paths to new role-global space (NOAA-EMC#3443)
  Enable CI testing on AWS (NOAA-EMC#3459)
  Enable Gaea C5 Jenkins CI (NOAA-EMC#3447)
  Job reference removal from WMO product names (NOAA-EMC#3460)
  Turn off aerosol prognostic radiative feedback for GDAS NOAA-EMC#2926 (NOAA-EMC#3445)
  Add DO_GEMPAK check to postsnd subtask (NOAA-EMC#3451)
  Add a force option to setup_xml to ignore unwritable directories (NOAA-EMC#3448)
  Remove the eomg job (NOAA-EMC#3331)
  Migration to role account for Jenkins on Orion (NOAA-EMC#3440)
  Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks (NOAA-EMC#3420)
  Update workflow staging for sfcanl tiles and waveinit (NOAA-EMC#3429)
  Improve messaging to display clear warning when missing snogrb file (NOAA-EMC#3317)
  JEDI-based ensemble recentering and analysis calculation (NOAA-EMC#3312)
  Enable HPSS archiving on C5/6 (NOAA-EMC#3437)
  Check if HOMEDIR STMP and PTMP are writable (NOAA-EMC#3430)
  Update UFS_Utils and GFS-utils hashes to update Gaea support and ocean/ice post products (NOAA-EMC#3433)
  Enable C1152 forecasts on gaea C6 (NOAA-EMC#3438)
  Migration to role account for Jenkins on Hercules (NOAA-EMC#3423)
  Remove Direct Linking to COM from DATA for `extractvars` Job (NOAA-EMC#3379)
  Enable HPSS via Globus on Hercules and Orion
  Remove job name from product files & update GEMPAK module. (NOAA-EMC#3415)
  `link` instead of `copy` in staging jobs (NOAA-EMC#3410)
  Migrate CI Jenkins to role account on Hera (NOAA-EMC#3414)
  Add rocotorc documentation when using scrontab (NOAA-EMC#3417)
  Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM (NOAA-EMC#3342)
  Add configuration for empirically-corrected ozone parameters (NOAA-EMC#3386)
  Enable global-workflow to run C768C384 GSI on Gaea-C6 (NOAA-EMC#3412)
  Move logical checks into if blocks (NOAA-EMC#3339)
  Adding Jenkins CI to GaeaC6 using role account (NOAA-EMC#3389)
  Enable GDASApp g-w CI cases to run on wcoss2 (NOAA-EMC#3399)
  CI/CD Test on Gaea C5- And update config.gaea under ci/platform (NOAA-EMC#3280)
  Enable cycling support for Gaea C6 (NOAA-EMC#3323)
  Update enkf archive jobs to use COMIN/COMOUT (NOAA-EMC#3393)
  Copy marine ensemble output observation diags and spread (NOAA-EMC#3407)
  Ci testing on aws 2 (NOAA-EMC#3408)
  Disable METplus jobs on Hera (NOAA-EMC#3403)
  Add the mean EnKF soil increment to the deterministic member (NOAA-EMC#3295)
  Add mpich/8.1.19 to the WCOSS2 LD_LIBRARY_PATH for GDASApp jobs (NOAA-EMC#3396)
  Change order of RUNs (NOAA-EMC#3335)
  CI testing on aws (NOAA-EMC#3391)
  Rename Gulf of Mexico in bufr station list in GFSv17 (NOAA-EMC#3384)
  Enabling AWS CI/testing (NOAA-EMC#3383)
  Update issue templates to use new issue type field (NOAA-EMC#3369)
  Replace WAVECUR_DID variable with "rtofs" (NOAA-EMC#3337)
  Allow for C1152 ATM-Aero cycled DA to run on WCOSS2 (NOAA-EMC#3309)
  Remove Direct Linking to COM from DATA for `wavepostsbs` Job (NOAA-EMC#3303)
  Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM (NOAA-EMC#3333)
  Add capability to run diff resolutions for marine anl and background (NOAA-EMC#3238)
  Update high resolution tests and fix minor wave issues  (NOAA-EMC#3289)
  Add sfs as valid system (NOAA-EMC#3243)
  Add missing arch_tars dependencies (NOAA-EMC#3319)
  Fix the empty aerosol DA aerostat tar file issue (NOAA-EMC#3332)
  Add missing file safeguard for IMS prep in snow analysis tasks (NOAA-EMC#3329)
  Fix memory unsetting on Gaea (NOAA-EMC#3325)
  Fix error log parsing in compute build CI (NOAA-EMC#3301)
  Remove marineanlvrfy task from global-workflow (NOAA-EMC#3314)
  Add `gfs_wavepostpnt` dependencies to gfs_cleanup (NOAA-EMC#3313)
  Increase the GDASApp build wallclock (NOAA-EMC#3298)
  Capture build fail in Jenkins pipeline when no error logs are produced (NOAA-EMC#3297)
  Add/update config files for Gaea and check existence before sourcing config files in generate_workflows.sh (NOAA-EMC#3286)
  Fix ocean restarts when cold starting with DOIAU=YES (NOAA-EMC#3278)
  Splitting up the archive task (NOAA-EMC#3242)
  CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos (NOAA-EMC#3256)
  Add esnowanl to enkfgfs cycle (NOAA-EMC#3283)
  Add gfs cycles to C48mx500_3DVarAOWCDA (NOAA-EMC#3249)
  Add fetch job and update stage_ic to work with fetched ICs (NOAA-EMC#3141)
  Remove WAFS files and references from `develop` (NOAA-EMC#3263)
  fix intel stack version number on c5 (NOAA-EMC#3258)
  Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252)
  Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255)
  Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres left review comments

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA left review comments

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA

@aerorahul aerorahul Awaiting requested review from aerorahul

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gfs cycles to C48mx500_3DVarAOWCDA
5 participants
@AntonMFernando-NOAA @JessicaMeixner-NOAA @WalterKolczynski-NOAA @emcbot @guillaumevernieres