Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture build fail in Jenkins pipeline when no error logs are produced #3297

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA commented Feb 4, 2025

Description

The catch block for a build fail in the Jenkins pipeline did not capture the case when there are no error logs produced.
This is has been rectified with this update. The compute build shell script still could be enhanced by creating a error.log file in the log directory.

Resolves #3296

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added bug Something isn't working CI/CD Issue related to CI/CD triage Issues that are triage labels Feb 4, 2025
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the quick fix.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit eee404c into NOAA-EMC:develop Feb 4, 2025
5 checks passed
@TerrenceMcGuinness-NOAA
Copy link
Collaborator Author

Rats, just missed the merge for the uptick for the gdas build though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD Issue related to CI/CD triage Issues that are triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins pipeline does not fail when build_compute.sh all fails
3 participants