Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the GDASApp build wallclock #3298

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

DavidHuber-NOAA
Copy link
Contributor

Description

This increases the build wallclock for the GDASApp to prevent CI timeouts.

Resolves #3296

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@aerorahul
Copy link
Contributor

are we sure this is not downloading data that is causing this to take this long to build?

@aerorahul
Copy link
Contributor

it cannot download the data from the compute node, so must be building for this long.

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Feb 4, 2025
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 hour is cutting it close, sometime the cmake step will be glacial, unrelated to downloading any data, so 1:30 should be safe

@WalterKolczynski-NOAA
Copy link
Contributor

it cannot download the data from the compute node, so must be building for this long.

The build was about "77%" done when it got killed. It shouldn't be able to download data from the compute queue, so I don't think that was the issue.

workflow/build_opts.yaml Outdated Show resolved Hide resolved
@aerorahul aerorahul merged commit 3d6c13e into NOAA-EMC:develop Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins pipeline does not fail when build_compute.sh all fails
5 participants