Add attributes to Gaussian grid sfcanl file #4149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerorahul
requested changes
Oct 14, 2025
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
|
Thanks for the suggestions @aerorahul, they make sense to me. Changes have been committed and starting CI on WCOSS2 and Gaea C6. |
aerorahul
approved these changes
Oct 14, 2025
|
Tests on Gaea C6 have passed: WCOSS2 tests had a snag unrelated to this PR and are rerunning. |
|
@WenMeng-NOAA - Can you do a quick spot check on the upp side for the tests run on Gaea? The v17 CI test COMROOT is located here: |
@CatherineThomas-NOAA Your test results look good to me. |
|
WCOSS2 CI tests (-G -E -S -C) were successful: Taking out of draft. |
CatherineThomas-NOAA
requested a review
from BrianCurtis-NOAA
as a code owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gaussian grid sfcanl file does not have the needed global attributes for upp. The attributes of imp_physics and landsfcmdl are missing and needed for upp to compute cloud and land fields consistently with the model. Upp assumes default values but the imp_physics default is inconsistent with what is used in GFSv17. This PR adds the needed attributes to the script and namelist for the gaussian sfcanl utility and updates the gfs_utils hash that allows the utility to read the new namelist.
Resolves #4113
Refs: NOAA-EMC/GFS#29 NOAA-EMC/gfs-utils#147
Type of change
Change characteristics
How has this been tested?
For NOAA-EMC/gfs-utils#148 - global-workflow CI tests (including cycling) on WCOSS2 as well as standalone UPP tests by @WenMeng-NOAA
Tested on WCOSS2 and Gaea C6 with latest g-w and gfs-utils changes - generate workflows -G -E -S -C tests passed. Output double checked by @WenMeng-NOAA.
Checklist