clean clang compile, prototypes C23 issue #301 #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#301 wgrib2 doesn't compile cleanly using clang
tested with AMD clang version 16.0.3 (CLANG: AOCC_4.2.0-Build#89 2023_12_13)
Some old obsolete features are either removed or deprecated from the working draft of C23:
.. K&R function definitions
Wgrib2 had problems and used the old style prototyping for
This fix addresses #309 (gcc 15) but wasn't tested with gcc 15.
I couldn't get prototyping of pointers to variadic functions to work, so
options which were variadic functions were converted to functions
with a constant number of arguments.