Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license (Apache 2.0) #105

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

romanc
Copy link
Collaborator

@romanc romanc commented Feb 10, 2025

Description

Add license as found missing in issue #85.

Fixes #85

How Has This Been Tested?

No tests have been done.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings: N/A
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

"Natural Language :: English",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.11",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but we require 3.11, so I though I'd change it along the way

@FlorianDeconinck
Copy link
Collaborator

@bensonr We are clear for this, correct?

@bensonr
Copy link

bensonr commented Feb 10, 2025

@FlorianDeconinck - I thought an earlier PR had taken care of licensing, but see it had not. Regardless, this is a derivative work and the license will be kept the same. I am checking as to who now owns the copyright.

@romanc
Copy link
Collaborator Author

romanc commented Feb 10, 2025

Frank added the Apache License to PyFV3 in NOAA-GFDL/PyFV3#31 if that is what you were having in mind.

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FlorianDeconinck
Copy link
Collaborator

Hold for Rusty's green light. Ok with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to propagate the Apache 2.0 license from Pace
4 participants