Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Type hint for precision dependant Float, Int #111

Conversation

FlorianDeconinck
Copy link
Collaborator

Type hint was too generic (type) leading to mypy throwing it's hand in the air and block all PRs (lint failure)

This should push sanity back into the linter

How Has This Been Tested?
Bug reproduced locally, pre-commit now passes.

@FlorianDeconinck FlorianDeconinck merged commit 597d1d4 into NOAA-GFDL:develop Feb 14, 2025
5 checks passed
@FlorianDeconinck FlorianDeconinck deleted the fix/type_hint_for_precision branch February 14, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants