-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic structure of pyFMS package #33
Basic structure of pyFMS package #33
Conversation
…gtstorage for testing
Added basic_operations.py from pyFV3/stencils to ndsl/stencils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pr looks good to me, have a few questions
1): assuming that the python files with "import ctypes" are python wrappers, not the ported python code, right?
2): should we add the python fms test to the pyFMS test directory instead of ndsl test directory?
|
Description
This PR sets the basic layout of the pyFMS package. The pyFMS package allows for interoperability between some of the modules contained within the Flexible Modeling System and NDSL. Code contained within this PR is purely structural and cannot be used as of yet for true interoperability.
Use of the pyFMS package is as follows:
A shared object library, compiled from the source Fortran code containing the desired c-binded FMS modules must be made local to the installation of NDSL. The desired location for the file is within NDSL/external/FMS
Each c-binded FMS module will have an analogous python module contained within, which will contain functions which obfuscate the Fortran functionality, allowing for them to be used in a "pythonic" way. This can be seen in the subdirectories of pyFMS.
The pyFMS module makes use of the
__init__.py
module method for importing of the FMS functionality. For example to call thefms_func
function the user would use the following format:How Has This Been Tested?
Tested via lint and currently implemented translate tests
OS: RHEL 8.9 Ootpa
Built conda environment using workflow in github action configurations
Checklist: