Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DaCe and GT4py to latest versions #43

Merged
merged 7 commits into from
May 21, 2024

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented May 14, 2024

Description
Recent commits to DaCe fix parsing issues present across pace and its submodules.

How Has This Been Tested?
Tested using currently implemented tests in NDSL tests directory
Tested update to NDSL effect on pace, pyFV3, and pySHiELD, with cpu and gpu orchestration methods

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@FlorianDeconinck
Copy link
Collaborator

Did you all Translate test in pyFV3 & pySHiELD under orchestration and on GPU?

@fmalatino fmalatino changed the title Update DaCe to latest version Update DaCe and GT4py to latest versions May 20, 2024
@fmalatino fmalatino marked this pull request as draft May 20, 2024 17:34
@fmalatino fmalatino marked this pull request as ready for review May 21, 2024 17:31
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyFV3 passes.
pySHiELD fails on Microphysics, but the failure seems to have been there for awhile and will be treated separately.

LGTM.

@fmalatino fmalatino merged commit 12cf113 into NOAA-GFDL:develop May 21, 2024
3 checks passed
@fmalatino fmalatino deleted the update/dace branch June 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants