Quantity factory to use dsl Float type as default

ndsl/grid/geometry.py

@@ -1,4 +1,5 @@
 from ndsl.comm.partitioner import TilePartitioner
+from ndsl.dsl.typing import Float
 from ndsl.grid.gnomonic import (
     get_lonlat_vect,
     get_unit_vector_direction,
@@ -591,7 +592,7 @@ def edge_factors(
     nhalo: int,
     tile_partitioner: TilePartitioner,
     rank: int,
-    radius: float,
+    radius: Float,
     np,
 ):
     """
@@ -704,7 +705,7 @@ def efactor_a2c_v(
     nhalo: int,
     tile_partitioner: TilePartitioner,
     rank: int,
-    radius: float,
+    radius: Float,
     np,
 ):
     """
@@ -888,7 +889,7 @@ def unit_vector_lonlat(grid, np):
     return unit_lon, unit_lat
 
 
-def _fill_halo_corners(field, value: float, nhalo: int, tile_partitioner, rank):
+def _fill_halo_corners(field, value: Float, nhalo: int, tile_partitioner, rank):
     """
     Fills a tile halo corners (ghost cells) of a field
     with a set value along the first 2 axes
@@ -905,7 +906,7 @@ def _fill_halo_corners(field, value: float, nhalo: int, tile_partitioner, rank):
             field[-nhalo:, -nhalo:] = value  # NE corner
 
 
-def _fill_single_halo_corner(field, value: float, nhalo: int, corner: str):
+def _fill_single_halo_corner(field, value: Float, nhalo: int, corner: str):
     """
     Fills a tile halo corner (ghost cells) of a field
     with a set value along the first 2 axes

ndsl/grid/helper.py

@@ -12,6 +12,7 @@
     split_cartesian_into_storages = None
 import ndsl.constants as constants
 from ndsl.constants import Z_DIM, Z_INTERFACE_DIM
+from ndsl.dsl.typing import Float
 from ndsl.filesystem import get_fs
 from ndsl.grid.generation import MetricTerms
 from ndsl.initialization.allocator import QuantityFactory
@@ -226,13 +227,13 @@ def dp(self) -> Quantity:
         return self._dp_ref
 
     @property
-    def ptop(self) -> float:
+    def ptop(self) -> Float:
         """
         top of atmosphere pressure (Pa)
         """
         if self.bk.view[0] != 0:
             raise ValueError("ptop is not well-defined when top-of-atmosphere bk != 0")
-        return float(self.ak.view[0])
+        return Float(self.ak.view[0])
 
 
 @dataclasses.dataclass(frozen=True)

ndsl/initialization/allocator.py

@@ -3,6 +3,7 @@
 import numpy as np
 
 from ndsl.constants import SPATIAL_DIMS
+from ndsl.dsl.typing import Float
 from ndsl.initialization.sizer import GridSizer
 from ndsl.optional_imports import gt4py
 from ndsl.quantity import Quantity, QuantityHaloSpec
@@ -60,7 +61,7 @@ def empty(
         self,
         dims: Sequence[str],
         units: str,
-        dtype: type = np.float64,
+        dtype: type = Float,
         allow_mismatch_float_precision: bool = False,
     ):
         return self._allocate(
@@ -71,7 +72,7 @@ def zeros(
         self,
         dims: Sequence[str],
         units: str,
-        dtype: type = np.float64,
+        dtype: type = Float,
         allow_mismatch_float_precision: bool = False,
     ):
         return self._allocate(
@@ -82,7 +83,7 @@ def ones(
         self,
         dims: Sequence[str],
         units: str,
-        dtype: type = np.float64,
+        dtype: type = Float,
         allow_mismatch_float_precision: bool = False,
     ):
         return self._allocate(
@@ -116,7 +117,7 @@ def _allocate(
         allocator: Callable,
         dims: Sequence[str],
         units: str,
-        dtype: type = np.float64,
+        dtype: type = Float,
         allow_mismatch_float_precision: bool = False,
     ):
         origin = self.sizer.get_origin(dims)
@@ -150,7 +151,7 @@ def get_quantity_halo_spec(
         self,
         dims: Sequence[str],
         n_halo: Optional[int] = None,
-        dtype: type = np.float64,
+        dtype: type = Float,
     ) -> QuantityHaloSpec:
         """Build memory specifications for the halo update.
 

ndsl/quantity.py

@@ -6,6 +6,7 @@
 
 import ndsl.constants as constants
 from ndsl.comm._boundary_utils import bound_default_slice, shift_boundary_slice_tuple
+from ndsl.dsl.typing import Float
 from ndsl.optional_imports import cupy, dace, gt4py
 from ndsl.optional_imports import xarray as xr
 from ndsl.types import NumpyModule
@@ -260,7 +261,8 @@ def _validate_quantity_property_lengths(shape, dims, origin, extent):
 def _is_float(dtype):
     """Expected floating point type for Pace"""
     return (
-        dtype == float
+        dtype == Float
+        or dtype == float
         or dtype == np.float32
         or dtype == np.float64
         or dtype == np.float16
@@ -296,9 +298,6 @@ def __init__(
                 storage attribute is disabled and will raise an exception. Will raise
                 a TypeError if this is given with a gt4py storage type as data
         """
-        # ToDo: [Florian 01/23] Kill the abomination.
-        # See https://github.com/NOAA-GFDL/pace/issues/3
-        from ndsl.dsl.typing import Float
 
         if (
             not allow_mismatch_float_precision