Changes to test configurations options and externals for parsing #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2024
Merged
bensonr
previously approved these changes
Jun 11, 2024
| @@ -370,7 +370,7 @@ def generate_parallel_stencil_tests(metafunc, *, backend: str): | |||
|
|
|||
|
|
|||
| def get_communicator(comm, layout, topology_mode): | |||
| if (MPI.COMM_WORLD.Get_size() > 1) and (topology_mode == "doubly-periodic"): | |||
| if (MPI.COMM_WORLD.Get_size() > 1) and (topology_mode == "cubed-sphere"): | |||
There was a problem hiding this comment.
This change will definitely make a big difference!!
There was a problem hiding this comment.
This was a bug I introduce in the PR right before
fmalatino
changed the title
fmalatino
changed the title
FlorianDeconinck
requested changes
Jun 13, 2024
ndsl/dsl/stencil.py
Outdated
| @@ -763,6 +763,7 @@ def axis_offsets( | |||
| "local_js": gtscript.J[0] + self.jsc - origin[1], | |||
| "j_end": j_end, | |||
| "local_je": gtscript.J[-1] + self.jec - origin[1] - domain[1] + 1, | |||
| "mysign": -1.0, | |||
There was a problem hiding this comment.
This is too aggressive as a fix. The axis_offsets function shouldn't carry the mysign issue.
| @@ -998,7 +997,7 @@ def fill_corners_dgrid_defn( | |||
| y_in (in): | |||
| y_out (inout): | |||
| """ | |||
| from __externals__ import i_end, i_start, j_end, j_start | |||
| from __externals__ import i_end, i_start, j_end, j_start, mysign | |||
There was a problem hiding this comment.
Pass it as a default externals or directly a scalar, since never changes in our code
| @@ -370,7 +370,7 @@ def generate_parallel_stencil_tests(metafunc, *, backend: str): | |||
|
|
|||
|
|
|||
| def get_communicator(comm, layout, topology_mode): | |||
| if (MPI.COMM_WORLD.Get_size() > 1) and (topology_mode == "doubly-periodic"): | |||
| if (MPI.COMM_WORLD.Get_size() > 1) and (topology_mode == "cubed-sphere"): | |||
There was a problem hiding this comment.
This was a bug I introduce in the PR right before
FlorianDeconinck
approved these changes
Jun 17, 2024
oelbert
approved these changes
Jun 18, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conditional statement in
stencils/testing/test_translate.pychanged to check forcomputepassed via the--gridpytest option.Switched conditional statement in
ndsl/stencils/testing/conftest.pyto check for option ofcubed-sphereselectionMade
mysignparameter offill_corners_dgrid_defnan external variableResolves Issue 52
How Has This Been Tested?
Tested in
pyFV3andpySHiELDtranslate tests github workflow.Checklist: