Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting changes to use of mysign in corners.py #59

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

fmalatino
Copy link
Contributor

Description
Regarding fixes to orchestration for unused variables, this change of mysign to an external variable is no longer necessary, and so to preserve the original state of the python source this change is being reverted.

How Has This Been Tested?
Tested via CI triggering translate tests across dependent repositories

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino requested a review from xyuan June 28, 2024 15:40
@fmalatino fmalatino marked this pull request as ready for review June 28, 2024 15:40
@fmalatino fmalatino merged commit 9afe641 into NOAA-GFDL:develop Jun 28, 2024
4 checks passed
@fmalatino fmalatino deleted the fix/mysign branch June 28, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants