-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reusable workflow CI - checkout corrrect repository #90
Conversation
@@ -1,26 +0,0 @@ | |||
name: "Main unit tests with mpich" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file must have snuck in somehow, it should not be in develop
@@ -1,26 +0,0 @@ | |||
name: "Main unit tests with openmpi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file must have snuck in somehow, it should not be in develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, probably should go in after PR 86
@fmalatino thank you helping me test the new CI 😃 |
* working baroclinic test case example (#81) * fixing dockerfile overriding netcdf, mpi4py, and numpy versions with mutually incompatible versions (#84) * Update notebooks for eta file creations (#85) * Update pace to use python 3.11.9 (#82) * Updated container for Github Action and reusable workflow (#87) * Updated container for Github Action and reusable workflow - Redo (#89) * Matching packages between main and develop branches and removal of outdated pull request template (#86) * Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt * Updating constraints file * Updating Dockerfile to use 3.11-slim-bookworm base python image * reusable workflow CI - checkout corrrect repository (#90) * pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py (#92) * Updated README to include directions for generating eta files (#99) * Updated submodules to most recent versions as of 3 Jan 2025 15:35 EST * Updated c5 build script to match new methods --------- Co-authored-by: Oliver Elbert <[email protected]> Co-authored-by: MiKyung Lee <[email protected]> Co-authored-by: mlee03 <[email protected]> Co-authored-by: Xingqiu Yuan <[email protected]>
Description
Currently, the CI checks out the incorrect repository and hash when the workflow is triggered externally. This PR fixes this issue.
Checklist: