Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Regrid Work #14

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

timothyas
Copy link
Member

Closes #13

To summarize that issue: the regridding algorithm was regridding all data variables, then subsetting only the variables we wanted to store. This reduces any potential extra work, by first subsetting the variables we care about, and then regridding.

Also, I changed how the yaml file is configured. I moved "regrid" to be a subsection of e.g. MOM6Dataset or CICE6Dataset, since in my view this is really just one component of the workflow. I'm curious what everyone thinks of that. Otherwise, I think it's fairly straightforward.

@timothyas
Copy link
Member Author

@danielabdi-noaa for some reason I'm unable to request you as a reviewer, but I'm wondering if you could review this whenever you get the chance. Thanks!

@danielabdi-noaa
Copy link
Contributor

@timothyas Just tested this and it does what it is supposed to do. What I tested include:

  • commenting out some of the "data_vars" entries, it does regridding only for active variables
  • Warning printed when rotation file not provided
  • Vector fields are included when rotation file provided
    Not really an issue, but when only "u0" is activated in "data_vars", "v0" is also included in the output due to the way
    the code is written.

I approve of this PR.

@timothyas
Copy link
Member Author

Awesome, thank you @danielabdi-noaa! @frolovsa I'm requesting your review in case you want to/have time to take a look.

@timothyas timothyas requested a review from frolovsa March 12, 2024 16:56
@timothyas
Copy link
Member Author

I just chatted with Sergey and I'll go ahead and merge this PR.

@timothyas timothyas merged commit 8b6450d into NOAA-PSL:main Mar 12, 2024
3 checks passed
@timothyas timothyas deleted the feature/reduce_regrid_work branch March 12, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra Regrid Work
2 participants