Skip to content

Commit

Permalink
revert back to excluding Ncomp from Q_evap_req
Browse files Browse the repository at this point in the history
  • Loading branch information
Yujie Xu committed Feb 28, 2024
1 parent 114ccb2 commit 472513a
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/EnergyPlus/HVACVariableRefrigerantFlow.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14551,7 +14551,7 @@ void VRFCondenserEquipment::VRFOU_CalcCompH(
NumOfCompSpdInput = this->CompressorSpeed.size();
CompEvaporatingPWRSpd.dimension(NumOfCompSpdInput);
CompEvaporatingCAPSpd.dimension(NumOfCompSpdInput);
Q_evap_req = TU_load + Pipe_Q;
Q_evap_req = TU_load + Pipe_Q - Ncomp;

TUListNum = this->ZoneTUListPtr;
RefrigerantIndex = FindRefrigerant(state, this->RefrigerantName);
Expand Down Expand Up @@ -14580,19 +14580,17 @@ void VRFCondenserEquipment::VRFOU_CalcCompH(
CompEvaporatingCAPSpd(CounterCompSpdTemp) =
this->CoffEvapCap * this->RatedEvapCapacity * CurveValue(state, this->OUCoolingCAPFT(CounterCompSpdTemp), T_discharge, T_suction);

if ((Q_evap_req * C_cap_operation) <= CompEvaporatingCAPSpd(CounterCompSpdTemp) + CompEvaporatingPWRSpd(CounterCompSpdTemp)) {
if ((Q_evap_req * C_cap_operation) <= CompEvaporatingCAPSpd(CounterCompSpdTemp)) {
// Compressor Capacity is greater than the required, finish Iteration DoName2

if (CounterCompSpdTemp > 1) {
// Compressor runs at higher speed than min speed
CompSpdLB = CounterCompSpdTemp - 1;
CompSpdUB = CounterCompSpdTemp;

CompSpdActual = this->CompressorSpeed(CompSpdLB) +
(this->CompressorSpeed(CompSpdUB) - this->CompressorSpeed(CompSpdLB)) /
(CompEvaporatingCAPSpd(CompSpdUB) + CompEvaporatingPWRSpd(CompSpdUB) -
(CompEvaporatingCAPSpd(CompSpdLB) + CompEvaporatingPWRSpd(CompSpdLB))) *
(Q_evap_req * C_cap_operation - (CompEvaporatingCAPSpd(CompSpdLB) + CompEvaporatingPWRSpd(CompSpdLB)));
CompSpdActual = this->CompressorSpeed(CompSpdLB) + (this->CompressorSpeed(CompSpdUB) - this->CompressorSpeed(CompSpdLB)) /
(CompEvaporatingCAPSpd(CompSpdUB) - CompEvaporatingCAPSpd(CompSpdLB)) *
(Q_evap_req * C_cap_operation - CompEvaporatingCAPSpd(CompSpdLB));
Modifi_SH = this->SH;
Ncomp = CompEvaporatingPWRSpd(CompSpdLB) + (CompEvaporatingPWRSpd(CompSpdUB) - CompEvaporatingPWRSpd(CompSpdLB)) /
(this->CompressorSpeed(CompSpdUB) - this->CompressorSpeed(CompSpdLB)) *
Expand Down

5 comments on commit 472513a

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfHeating3 (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2758 of 2758 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfHeating3 (Unknown) - x86_64-MacOS-10.18-clang-15.0.0: OK (3269 of 3545 tests passed, 255 test warnings)

Messages:\n

  • 463 tests had: DXF diffs.
  • 275 tests had: Table big diffs.
  • 34 tests had: EIO diffs.
  • 8 tests had: SSZ big diffs.
  • 26 tests had: AUD diffs.
  • 22 tests had: ESO small diffs.
  • 13 tests had: MTR small diffs.
  • 5 tests had: RDD diffs.
  • 15 tests had: Table small diffs.
  • 3 tests had: IDF diffs.
  • 1 test had: BND diffs.
  • 5 tests had: ERR diffs.
  • 4 tests had: ESO big diffs.
  • 2 tests had: MTR big diffs.

Failures:\n

regression Test Summary

  • Passed: 511
  • Failed: 275

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfHeating3 (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3310 of 3586 tests passed, 258 test warnings)

Messages:\n

  • 466 tests had: DXF diffs.
  • 276 tests had: Table big diffs.
  • 31 tests had: EIO diffs.
  • 8 tests had: SSZ big diffs.
  • 26 tests had: AUD diffs.
  • 22 tests had: ESO small diffs.
  • 13 tests had: MTR small diffs.
  • 5 tests had: RDD diffs.
  • 15 tests had: Table small diffs.
  • 3 tests had: IDF diffs.
  • 1 test had: BND diffs.
  • 4 tests had: ERR diffs.
  • 4 tests had: ESO big diffs.
  • 2 tests had: MTR big diffs.

Failures:\n

regression Test Summary

  • Passed: 530
  • Failed: 276

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfHeating3 (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1971 of 1971 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfHeating3 (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (790 of 790 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.