Add density option to ZoneInfiltration:DesignFlowRate and ZoneVentilation:DesignFlowRate #10929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjwitte
added
NewFeature
|
mjwitte
commented
Feb 7, 2025
| @@ -908,6 +911,10 @@ void GetSimpleAirModelInputs(EnergyPlusData &state, bool &ErrorsFound) // IF err | |||
| ShowContinueError(state, "Infiltration Coefficients are all zero. No Infiltration will be reported."); | |||
| } | |||
| } | |||
| if (!lAlphaFieldBlanks(5)) { | |||
There was a problem hiding this comment.
Since #10295, and when using getObjectItem, you don't have to check if the field is blank if it has a default, even if the field is not present. I know it's a little scary to go there but the field will get stuffed with the default even after min fields (A5 is past min-fields = 12). 5ZoneEndUses - but any file will show this result. I'm not asking for a change here just pointing out a new field rule.
Comment on lines
+5524
to
+5526
| Real64 AirDensity = 0.0; // Density of air for converting from volume flow to mass flow (kg/m^3) | ||
| switch (thisVentilation.densityBasis) { | ||
| case DataHeatBalance::InfVentDensityBasis::Standard: { |
There was a problem hiding this comment.
Add switch to set desired density for ventilation calculation.
Comment on lines
+6425
to
+6427
| Real64 AirDensity = 0.0; // Density of air for converting from volume flow to mass flow (kg/m^3) | ||
| switch (thisInfiltration.densityBasis) { | ||
| case DataHeatBalance::InfVentDensityBasis::Standard: { |
There was a problem hiding this comment.
And here for infiltration.
| @@ -219,6 +219,21 @@ TEST_F(EnergyPlusFixture, InfiltrationObjectLevelReport) | |||
| " 0, !- Velocity Term Coefficient", | |||
| " 0; !- Velocity Squared Term Coefficient", | |||
|
|
|||
| "ZoneInfiltration:DesignFlowRate,", | |||
There was a problem hiding this comment.
And then extend some unit tests.
mjwitte
changed the title
|
|
|
Diffs are as expected, table diffs like this. |
mjwitte
added
Defect
Myoldmopar
approved these changes
Feb 13, 2025
|
Passes happily with latest develop, thanks @mjwitte |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
Add new field for Density Basis to ZoneInfiltration:DesignFlowRate and ZoneVentilation:DesignFlowRate objects.
Pull Request Author
If any defect files are updated to a more recent version, upload new versions here or on DevSupportIf IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange labelIf structural output changes, add to output rules file and add OutputChange labelIf adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependenciesReviewer