Fix #10926 - Disable fused floating point operations

[jmarrec]

Pull request overview

• Fixes Investigate diffs on Apple Silicon when running regression tests #10926

read https://clang.llvm.org/docs/UsersManual.html#cmdoption-ffp-contract

Clang, unlike GCC, sets that to on by default.

Tested this with another branch: https://github.com/NREL/EnergyPlus/tree/10926-baseline

My branch1 is 10926-baseline

• took develop
• Reverted the merge commit of the Window Refactor PR

On this branch 10926-Diff-Apple, I checkout develop. I run the 1ZoneUncontrolled_win_1 test, and I get diffs between the two branches.

(This is essentially the same as if 10926-Diff-Apple was the Window Refactor PR, and 10926-baseline was develop at that point in time)

Then on BOTH branch, I set -ffp-contract=off. Rerun the test, diffs are gone.

---

Please see some discussion on 3b856a0#commitcomment-152282537

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[github-actions]

⚠️ Regressions detected on macos-14 for commit 56c9b6d

Regression Summary

• EIO: 685
• EDD: 12
• ESO Small Diffs: 744
• MTR Small Diffs: 581
• Table Small Diffs: 628
• Table String Diffs: 292
• SSZ Small Diffs: 208
• ZSZ Small Diffs: 300
• MAP: 1
• JSON Big Diffs: 4
• ERR: 61
• Table Big Diffs: 66
• ESO Big Diffs: 29
• MTR Big Diffs: 10
• DELightIn: 1
• DELightOut: 1
• SSZ Big Diffs: 3
• ZSZ Big Diffs: 2
• GLHE: 2

• View Results
• Download Regressions

[jmarrec]

the mac regressions are expected. It's the point of the PR.

[Myoldmopar]

Regressions are fine, but the unit test failure will have to be addressed before merging that into develop. If you would like help debugging that, just let me know.