Skip to content

Commit

Permalink
Update sizing tests since pipe diameter affects bore length.
Browse files Browse the repository at this point in the history
  • Loading branch information
joseph-robertson committed Nov 21, 2023
1 parent f53e307 commit aac78ef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions HPXMLtoOpenStudio/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>1514c9e1-0bfb-46e3-a387-64747abce65c</version_id>
<version_modified>2023-11-21T14:20:22Z</version_modified>
<version_id>e2954b03-99a0-4e2f-a076-a4f1a8bee83f</version_id>
<version_modified>2023-11-21T15:32:09Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -622,7 +622,7 @@
<filename>test_hvac_sizing.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>CA23771E</checksum>
<checksum>716C37CA</checksum>
</file>
<file>
<filename>test_lighting.rb</filename>
Expand Down
6 changes: 3 additions & 3 deletions HPXMLtoOpenStudio/tests/test_hvac_sizing.rb
Original file line number Diff line number Diff line change
Expand Up @@ -477,15 +477,15 @@ def test_ground_loop
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
_model, _test_hpxml, test_hpxml_bldg = _test_measure(args_hash)
assert_equal(3, test_hpxml_bldg.geothermal_loops[0].num_bore_holes)
assert_in_epsilon(776.7 / 3 + 5.0, test_hpxml_bldg.geothermal_loops[0].bore_length, 0.01)
assert_in_epsilon(688.5 / 3 + 5.0, test_hpxml_bldg.geothermal_loops[0].bore_length, 0.01)

# Bore depth greater than the max -> increase number of boreholes
hpxml, hpxml_bldg = _create_hpxml('base-hvac-ground-to-air-heat-pump.xml')
hpxml_bldg.site.ground_conductivity = 0.2
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
_model, _test_hpxml, test_hpxml_bldg = _test_measure(args_hash)
assert_equal(5, test_hpxml_bldg.geothermal_loops[0].num_bore_holes)
assert_in_epsilon(2151.1 / 5 + 5, test_hpxml_bldg.geothermal_loops[0].bore_length, 0.01)
assert_in_epsilon(2062.9 / 5 + 5, test_hpxml_bldg.geothermal_loops[0].bore_length, 0.01)

# Bore depth greater than the max -> increase number of boreholes until the max, set depth to the max, and issue warning
hpxml, hpxml_bldg = _create_hpxml('base-hvac-ground-to-air-heat-pump.xml')
Expand All @@ -501,7 +501,7 @@ def test_ground_loop
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
_model, _test_hpxml, test_hpxml_bldg = _test_measure(args_hash)
assert_equal(10, test_hpxml_bldg.geothermal_loops[0].num_bore_holes)
assert_in_epsilon(3761.5 / 10 + 5, test_hpxml_bldg.geothermal_loops[0].bore_length, 0.01)
assert_in_epsilon(3187.0 / 10 + 5, test_hpxml_bldg.geothermal_loops[0].bore_length, 0.01)
end

def test_g_function_library_linear_interpolation_example
Expand Down

0 comments on commit aac78ef

Please sign in to comment.