Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sizing method #1563

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Remove sizing method #1563

merged 1 commit into from
Dec 4, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Dec 4, 2023

Pull Request Description

Method was deprecated in b2b89b8.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Dec 4, 2023
@shorowit shorowit merged commit 43bd6ee into master Dec 4, 2023
6 checks passed
@shorowit shorowit deleted the remove_sizing_method branch December 4, 2023 19:42
@joseph-robertson joseph-robertson mentioned this pull request Dec 20, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant