Whole building MF inter-unit heat transfer #1850

yzhou601 · 2024-10-04T21:16:11Z

Pull Request Description

Addresses #1499. Adds ability to model inter-unit heat transfer. Also documents a workaround for modeling MF common spaces.

Checklist

Not all may apply:

Schematron validator (EPvalidator.xml) has been updated
Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

…o whole_building_common_spaces

HPXMLtoOpenStudio/resources/model.rb

shorowit

Great to see some progress! A couple initial questions/thoughts.

HPXMLtoOpenStudio/resources/geometry.rb

HPXMLtoOpenStudio/resources/model.rb

yzhou601 · 2024-10-04T23:06:53Z

The approach seems working! 🎉 Going to make this PR more concrete next.

…o whole_building_common_spaces

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

shorowit · 2024-10-22T20:33:16Z

HPXMLtoOpenStudio/resources/model.rb

      end
    end
+
+    model_objects.each do |obj|


Currently it feels a bit more complicated than I would have expected just because you're operating on the objects of the final merged model, so you have to know which surfaces are linked and what space to attach them to. I wonder if this can be simplified.

The latest a few commit tried to simplify it a bit further (first one makes it working). I removed two methods in the hpxml.rb and only keeps the sameas which returns the fully described object. I stored the adjacent surface ids directly to the OS:Space additional properties, and I stored all the HPXML ids to OS:Surface additional properties. In this way, after merging, I can use OS:Space to find the OS:Surface. It's more straightforward and less coding compared to previous approach. However, the adjacency still happens after merging, I think this execution point is determined in the first place, mainly because that the OS:Surface and the OS:Space is not in the same workspace before merging, so it's not able to create adjacent surface using OS:Space outside the scope. Let me know if you have any thoughts.

…o whole_building_common_spaces

…ace, store hpxml id in all surfaces, removed one more method in hpxml.rb, code cleanup

yzhou601 · 2024-10-24T01:14:06Z

One more remaining question related to calling individual dwelling unit (wrote down in case I forgot): Should we enforce the surfaces with full descriptions to be specified in conditioned dwelling units so that they can be called alone? Technically for surfaces connecting two Building elements, users can specify the surface full description in either Building element, which will make the call of running individual dwelling unit error-prone. We can either:

Only allow whole building simulation when sameas is provided, then the surface inputs can be specified in either Building element, or:
Only allow surface full descriptions all in conditioned units, and the user can call building ids of conditioned units to simulate individual dwelling units

Honestly I was implementing assuming the former in the first place, considering how MulTEA uses this feature (and floors are always specified as floors(vs. celing) in MulTEA inputs, so the full descriptions can be in the unconditioned Building element), but I'm fine with the second for more flexibility.

…o whole_building_common_spaces

yzhou601 · 2024-10-24T03:14:36Z

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

-      <sch:assert role='ERROR' test='count(h:Roofs/h:Roof[h:InteriorAdjacentTo="conditioned space"]) + count(h:Floors/h:Floor[h:InteriorAdjacentTo="conditioned space" and (h:ExteriorAdjacentTo="attic - vented" or h:ExteriorAdjacentTo="attic - unvented" or ((h:ExteriorAdjacentTo="other housing unit" or h:ExteriorAdjacentTo="other heated space" or h:ExteriorAdjacentTo="other multifamily buffer space" or h:ExteriorAdjacentTo="other non-freezing space") and h:FloorOrCeiling="ceiling"))]) &gt;= 1'>There must be at least one ceiling or roof adjacent to conditioned space.</sch:assert>
-      <sch:assert role='ERROR' test='count(h:Walls/h:Wall[h:InteriorAdjacentTo="conditioned space" and h:ExteriorAdjacentTo="outside"]) &gt;= 1'>There must be at least one exterior wall adjacent to conditioned space.</sch:assert>
-      <sch:assert role='ERROR' test='count(h:Slabs/h:Slab[contains(h:InteriorAdjacentTo, "conditioned")]) + count(h:Floors/h:Floor[h:InteriorAdjacentTo="conditioned space" and not(h:ExteriorAdjacentTo="attic - vented" or h:ExteriorAdjacentTo="attic - unvented" or ((h:ExteriorAdjacentTo="other housing unit" or h:ExteriorAdjacentTo="other heated space" or h:ExteriorAdjacentTo="other multifamily buffer space" or h:ExteriorAdjacentTo="other non-freezing space") and h:FloorOrCeiling="ceiling"))]) &gt;= 1'>There must be at least one floor or slab adjacent to conditioned space.</sch:assert>
+      <sch:assert role='ERROR' test='count(h:Roofs/h:Roof[h:InteriorAdjacentTo="conditioned space"]) + count(h:Floors/h:Floor[h:InteriorAdjacentTo="conditioned space" and (h:ExteriorAdjacentTo="attic - vented" or h:ExteriorAdjacentTo="attic - unvented" or ((h:ExteriorAdjacentTo="other housing unit" or h:ExteriorAdjacentTo="other heated space" or h:ExteriorAdjacentTo="other multifamily buffer space" or h:ExteriorAdjacentTo="other non-freezing space") and h:FloorOrCeiling="ceiling"))]) + count(h:Floors/h:Floor[h:SystemIdentifier/@sameas]) &gt;= 1'>There must be at least one ceiling or roof adjacent to conditioned space.</sch:assert>


I relaxed this rule to count "sameas" floor also as a ceiling/floor(two lines below), but we have no better knowledge of whether it's a floor or ceiling, or if user only specifies one of them. Let me know if any better thought.

yzhou601 · 2024-10-24T03:15:18Z

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

-      <sch:assert role='ERROR' test='count(h:Walls/h:Wall[h:InteriorAdjacentTo="conditioned space" and h:ExteriorAdjacentTo="outside"]) &gt;= 1'>There must be at least one exterior wall adjacent to conditioned space.</sch:assert>
-      <sch:assert role='ERROR' test='count(h:Slabs/h:Slab[contains(h:InteriorAdjacentTo, "conditioned")]) + count(h:Floors/h:Floor[h:InteriorAdjacentTo="conditioned space" and not(h:ExteriorAdjacentTo="attic - vented" or h:ExteriorAdjacentTo="attic - unvented" or ((h:ExteriorAdjacentTo="other housing unit" or h:ExteriorAdjacentTo="other heated space" or h:ExteriorAdjacentTo="other multifamily buffer space" or h:ExteriorAdjacentTo="other non-freezing space") and h:FloorOrCeiling="ceiling"))]) &gt;= 1'>There must be at least one floor or slab adjacent to conditioned space.</sch:assert>
+      <sch:assert role='ERROR' test='count(h:Roofs/h:Roof[h:InteriorAdjacentTo="conditioned space"]) + count(h:Floors/h:Floor[h:InteriorAdjacentTo="conditioned space" and (h:ExteriorAdjacentTo="attic - vented" or h:ExteriorAdjacentTo="attic - unvented" or ((h:ExteriorAdjacentTo="other housing unit" or h:ExteriorAdjacentTo="other heated space" or h:ExteriorAdjacentTo="other multifamily buffer space" or h:ExteriorAdjacentTo="other non-freezing space") and h:FloorOrCeiling="ceiling"))]) + count(h:Floors/h:Floor[h:SystemIdentifier/@sameas]) &gt;= 1'>There must be at least one ceiling or roof adjacent to conditioned space.</sch:assert>
+      <sch:assert role='ERROR' test='count(h:Walls/h:Wall[h:InteriorAdjacentTo="conditioned space" and h:ExteriorAdjacentTo="outside"]) + count(h:FoundationWalls/h:FoundationWall[h:InteriorAdjacentTo="conditioned space" and h:ExteriorAdjacentTo="ground"]) + count(h:Walls/h:Wall[h:SystemIdentifier/@sameas]) + count(h:FoundationWalls/h:FoundationWall[h:SystemIdentifier/@sameas]) &gt;= 1'>There must be at least one exterior wall or foundation wall adjacent to conditioned space.</sch:assert> <!-- FIXME: Should we relax this restriction for internal zones? -->


A basement can be a separate Building element, So I added foundation wall here too.

…resolve later)

…L/OpenStudio-HPXML into whole_building_common_spaces

…o whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv

…NREL/OpenStudio-HPXML into whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv

…o whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml

…o whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hpxml.rb # ReportUtilityBills/measure.xml # tasks.rb # workflow/hpxml_inputs.json # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_hvac.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv # workflow/tests/util.rb

…o whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_hvac.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv # workflow/tests/base_results/results_simulations_panel.csv

…io-HPXML into whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_hvac.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv

…o whole_building_common_spaces

shorowit · 2025-10-15T21:45:49Z

TODO:

@shorowit remove Foundation & Attic elements for multea translator and commit
@shorowit document sameas inter-unit heat transfer
@yzhou601 add whole-building test HPXML that uses attic/foundation slices
@yzhou601 what error if e.g. wall references floor?
@yzhou601 update base-bldgtype-mf-whole-building-common-spaces.xml to use more descriptive building IDs

…o whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml

yzhou601 added 3 commits October 4, 2024 14:57

same as adjacency first cut

57e268c

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

8edc860

…o whole_building_common_spaces

update measures

37aac01

yzhou601 self-assigned this Oct 4, 2024

yzhou601 commented Oct 4, 2024

View reviewed changes

HPXMLtoOpenStudio/resources/model.rb Outdated Show resolved Hide resolved

shorowit reviewed Oct 4, 2024

View reviewed changes

HPXMLtoOpenStudio/resources/geometry.rb Outdated Show resolved Hide resolved

HPXMLtoOpenStudio/resources/model.rb Outdated Show resolved Hide resolved

yzhou601 added 2 commits October 4, 2024 16:49

simplify implementation with additional properties

db9794d

oops

4ea65c6

yzhou601 added 5 commits October 11, 2024 17:31

skipped creating duplicate surfaces, addressed default and hvac sizing

e0979da

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

5ee2c83

…o whole_building_common_spaces

bugfix, name change

c96242e

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

edd9aee

…o whole_building_common_spaces

change to only use sameas in one element instead of both elements

ad4c8a0

shorowit reviewed Oct 22, 2024

View reviewed changes

yzhou601 added 5 commits October 22, 2024 16:23

bugfix and some cleanups

c31f15d

simplify EPvalidator.xml

bb5e641

update measures

c1f0dd3

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

11f013f

…o whole_building_common_spaces

simplified the approach further more: store adjacent surface id in sp…

a1126ef

…ace, store hpxml id in all surfaces, removed one more method in hpxml.rb, code cleanup

yzhou601 added 3 commits October 23, 2024 20:52

Add test file to include unconditioned common spaces and shared surfaces

6c065d6

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

6cad724

…o whole_building_common_spaces

Oops, forgot to add the generated test file

4f0e0dd

yzhou601 commented Oct 24, 2024

View reviewed changes

yzhou601 and others added 4 commits October 23, 2024 21:22

more fix

774b737

test validations

a8a6c50

fixed util.rb, relax the unused schedule check for common spaces(may …

388025e

…resolve later)

Latest results.

60feccc

shorowit changed the title ~~Whole building Common Spaces~~ Whole building MF Common Spaces Nov 12, 2024

yzhou601 and others added 4 commits January 22, 2025 17:06

add reverse surface description test file

98d4b67

Latest results.

fc65762

add EPvalidator check for wholebuildingsimulation

6a0e79c

Merge branch 'whole_building_common_spaces' of https://github.com/NRE…

8b631ae

…L/OpenStudio-HPXML into whole_building_common_spaces

shorowit mentioned this pull request Jan 21, 2025

Enhancements for whole SFA/MF buildings #1499

Open

7 tasks

shorowit and others added 10 commits February 18, 2025 10:12

Update new code merged in.

c466bf0

Latest results.

2dc8a4b

Latest results.

ebf8f18

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

71e0e0d

…o whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml

Latest results.

c820ed5

Latest results.

5cf23c1

shorowit moved this from In progress to Blocker/On Hold in OpenStudio-HPXML Jun 24, 2025

shorowit moved this from Blocker/On Hold to In progress in OpenStudio-HPXML Sep 16, 2025

shorowit and others added 5 commits October 10, 2025 12:27

Update HPXMLs.

a7f09ad

Update log message check

51ca338

Latest results.

3fb9730

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

7f95a40

…o whole_building_common_spaces

shorowit and others added 4 commits October 15, 2025 16:37

Reduce scope of changes

b45c1aa

Improve IDs for multi-unit HPXMLs.

f1eb1e5

Latest results.

2a41960

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

645c8ce

…o whole_building_common_spaces # Conflicts: # HPXMLtoOpenStudio/measure.xml

shorowit changed the title ~~Whole building MF Common Spaces~~ Whole building MF inter-unit heat transfer Oct 21, 2025

shorowit added 2 commits October 21, 2025 09:07

Rename sample file.

3a58bdc

Update documentation/changelog. Revert sample file name change.

107ecde

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Whole building MF inter-unit heat transfer #1850

Whole building MF inter-unit heat transfer #1850

Uh oh!

yzhou601 commented Oct 4, 2024 •

edited by shorowit

Loading

Uh oh!

Uh oh!

shorowit left a comment

Uh oh!

Uh oh!

Uh oh!

yzhou601 commented Oct 4, 2024 •

edited

Loading

Uh oh!

Uh oh!

shorowit Oct 22, 2024

Uh oh!

yzhou601 Oct 23, 2024

Uh oh!

yzhou601 commented Oct 24, 2024 •

edited

Loading

Uh oh!

yzhou601 Oct 24, 2024

Uh oh!

yzhou601 Oct 24, 2024

Uh oh!

shorowit commented Oct 15, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Whole building MF inter-unit heat transfer #1850

Are you sure you want to change the base?

Whole building MF inter-unit heat transfer #1850

Uh oh!

Conversation

yzhou601 commented Oct 4, 2024 • edited by shorowit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Checklist

Uh oh!

Uh oh!

shorowit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yzhou601 commented Oct 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shorowit Oct 22, 2024

Choose a reason for hiding this comment

Uh oh!

yzhou601 Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

yzhou601 commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yzhou601 Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

yzhou601 Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

shorowit commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yzhou601 commented Oct 4, 2024 •

edited by shorowit

Loading

yzhou601 commented Oct 4, 2024 •

edited

Loading

yzhou601 commented Oct 24, 2024 •

edited

Loading

shorowit commented Oct 15, 2025 •

edited

Loading