BuildResidentialHPXML: make conditional arguments optional

BuildResidentialHPXML/resources/constants.rb

@@ -2,6 +2,7 @@
 
 # Collection of constants.
 module Constants
+  Auto = 'auto'
   BuildingAmerica = 'BuildingAmerica'
   FacadeFront = 'front'
   FacadeBack = 'back'
@@ -16,3 +17,12 @@ module Constants
   RoofTypeGable = 'gable'
   RoofTypeHip = 'hip'
 end
+
+# TODO
+module Argument
+  Choice = 'makeChoiceArgument'
+  String = 'makeStringArgument'
+  Double = 'makeDoubleArgument'
+  Integer = 'makeIntegerArgument'
+  Boolean = 'makeBoolArgument'
+end

BuildResidentialHPXML/resources/geometry.rb

@@ -676,10 +676,10 @@ def self.create_single_family_attached(model:,
                                          geometry_attic_type:,
                                          geometry_roof_type:,
                                          geometry_roof_pitch:,
-                                         geometry_unit_left_wall_is_adiabatic:,
-                                         geometry_unit_right_wall_is_adiabatic:,
-                                         geometry_unit_front_wall_is_adiabatic:,
-                                         geometry_unit_back_wall_is_adiabatic:,
+                                         geometry_unit_left_wall_is_adiabatic: false,
+                                         geometry_unit_right_wall_is_adiabatic: false,
+                                         geometry_unit_front_wall_is_adiabatic: false,
+                                         geometry_unit_back_wall_is_adiabatic: false,
                                          **)
 
     cfa = geometry_unit_cfa
@@ -976,10 +976,10 @@ def self.create_apartment(model:,
                             geometry_attic_type:,
                             geometry_roof_type:,
                             geometry_roof_pitch:,
-                            geometry_unit_left_wall_is_adiabatic:,
-                            geometry_unit_right_wall_is_adiabatic:,
-                            geometry_unit_front_wall_is_adiabatic:,
-                            geometry_unit_back_wall_is_adiabatic:,
+                            geometry_unit_left_wall_is_adiabatic: false,
+                            geometry_unit_right_wall_is_adiabatic: false,
+                            geometry_unit_front_wall_is_adiabatic: false,
+                            geometry_unit_back_wall_is_adiabatic: false,
                             **)
 
     cfa = geometry_unit_cfa
@@ -1375,14 +1375,10 @@ def self.create_doors(runner:,
   #
   # @param runner [OpenStudio::Measure::OSRunner] Object typically used to display warnings
   # @param model [OpenStudio::Model::Model] OpenStudio Model object
-  # @param window_front_wwr [Double] ratio of window to wall area for the unit's front facade (frac)
-  # @param window_back_wwr [Double] ratio of window to wall area for the unit's back facade (frac)
-  # @param window_left_wwr [Double] ratio of window to wall area for the unit's left facade (frac)
-  # @param window_right_wwr [Double] ratio of window to wall area for the unit's right facade (frac)
-  # @param window_area_front [Double] amount of window area on unit's front facade (ft2)
-  # @param window_area_back [Double] amount of window area on unit's back facade (ft2)
-  # @param window_area_left [Double] amount of window area on unit's left facade (ft2)
-  # @param window_area_right [Double] amount of window area on unit's right facade (ft2)
+  # @param window_area_front [Double] amount of window area on unit's front facade or window to wall ratio if less than 1 (ft2 or frac)
+  # @param window_area_back [Double] amount of window area on unit's back facade or window to wall ratio if less than 1 (ft2 or frac)
+  # @param window_area_left [Double] amount of window area on unit's left facade or window to wall ratio if less than 1 (ft2 or frac)
+  # @param window_area_right [Double] amount of window area on unit's right facade or window to wall ratio if less than 1 (ft2 or frac)
   # @param window_aspect_ratio [Double] ratio of window height to width (frac)
   # @param skylight_area_front [Double] amount of skylight area on the unit's front conditioned roof facade (ft2)
   # @param skylight_area_back [Double] amount of skylight area on the unit's back conditioned roof facade (ft2)
@@ -1391,32 +1387,28 @@ def self.create_doors(runner:,
   # @return [Boolean] true if successful
   def self.create_windows_and_skylights(runner:,
                                         model:,
-                                        window_front_wwr:,
-                                        window_back_wwr:,
-                                        window_left_wwr:,
-                                        window_right_wwr:,
                                         window_area_front:,
                                         window_area_back:,
                                         window_area_left:,
                                         window_area_right:,
                                         window_aspect_ratio:,
-                                        skylight_area_front:,
-                                        skylight_area_back:,
-                                        skylight_area_left:,
-                                        skylight_area_right:,
+                                        skylight_area_front: 0,
+                                        skylight_area_back: 0,
+                                        skylight_area_left: 0,
+                                        skylight_area_right: 0,
                                         **)
     facades = [Constants::FacadeBack, Constants::FacadeRight, Constants::FacadeFront, Constants::FacadeLeft]
 
     wwrs = {}
-    wwrs[Constants::FacadeBack] = window_back_wwr
-    wwrs[Constants::FacadeRight] = window_right_wwr
-    wwrs[Constants::FacadeFront] = window_front_wwr
-    wwrs[Constants::FacadeLeft] = window_left_wwr
+    wwrs[Constants::FacadeBack] = (window_area_back < 1 ? window_area_back : 0.0)
+    wwrs[Constants::FacadeRight] = (window_area_right < 1 ? window_area_right : 0.0)
+    wwrs[Constants::FacadeFront] = (window_area_front < 1 ? window_area_front : 0.0)
+    wwrs[Constants::FacadeLeft] = (window_area_left < 1 ? window_area_left : 0.0)
     window_areas = {}
-    window_areas[Constants::FacadeBack] = window_area_back
-    window_areas[Constants::FacadeRight] = window_area_right
-    window_areas[Constants::FacadeFront] = window_area_front
-    window_areas[Constants::FacadeLeft] = window_area_left
+    window_areas[Constants::FacadeBack] = (window_area_back >= 1 ? window_area_back : 0.0)
+    window_areas[Constants::FacadeRight] = (window_area_right >= 1 ? window_area_right : 0.0)
+    window_areas[Constants::FacadeFront] = (window_area_front >= 1 ? window_area_front : 0.0)
+    window_areas[Constants::FacadeLeft] = (window_area_left >= 1 ? window_area_left : 0.0)
 
     skylight_areas = {}
     skylight_areas[Constants::FacadeBack] = skylight_area_back