Update HVAC models per RESNET HVAC addendum #1879

yzhou601 · 2024-11-09T05:22:55Z

Pull Request Description

closes #1871

Checklist

Not all may apply:

Schematron validator (EPvalidator.xml) has been updated
Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

…o resnet_heat_pump

…same resnet updates, remove in.schedules.csv in test_hvac.rb

…, etc.

…-HPXML into resnet_heat_pump

…o resnet_heat_pump

yzhou601 · 2024-11-15T19:39:26Z

HPXMLtoOpenStudio/resources/defaults.rb

+
+      if (not heating_system.attached_cooling_system.nil?) && (not heating_system.attached_cooling_system.compressor_type.nil?)
+        # Based on RESNET DX Modeling Appendix
+        heating_system.fan_model_type = (heating_system.attached_cooling_system.compressor_type == HPXML::HVACCompressorTypeSingleStage) ? HPXML::HVACFanModelTypePSC : HPXML::HVACFanModelTypeBPM


For attached heating and cooling systems, grab the cooling compressor type first to default, otherwise follow the previous HEScore assumption (based on efficiency)

yzhou601 · 2024-11-15T19:40:26Z

HPXMLtoOpenStudio/resources/defaults.rb

+        cooling_system.fan_model_type = (cooling_system.compressor_type == HPXML::HVACCompressorTypeSingleStage) ? HPXML::HVACFanModelTypePSC : HPXML::HVACFanModelTypeBPM
+        cooling_system.fan_model_type_isdefaulted = true
+      elsif [HPXML::HVACTypeMiniSplitAirConditioner].include? cooling_system.cooling_system_type
+        cooling_system.fan_model_type = HPXML::HVACFanModelTypeBPM


Always assume BPM for minisplit, as they're variable speed systems?

yzhou601 · 2024-11-15T19:42:23Z

HPXMLtoOpenStudio/resources/defaults.rb

+        heat_pump.fan_model_type = (heat_pump.compressor_type == HPXML::HVACCompressorTypeSingleStage) ? HPXML::HVACFanModelTypePSC : HPXML::HVACFanModelTypeBPM
+        heat_pump.fan_model_type_isdefaulted = true
+      elsif [HPXML::HVACTypeHeatPumpGroundToAir].include? heat_pump.heat_pump_type
+        if heat_pump.heating_efficiency_cop > 8.75 / 3.2 # HEScore assumption


This is kept the same as previous assumptions, need to discuss when we have two speed/var speed GSHP capabilities. Not sure for that case should it follow the RESNET assumption dependent on speed number or should it be something else (out of RESNET scope).

yzhou601 · 2024-11-15T19:44:29Z

HPXMLtoOpenStudio/resources/hvac.rb

+      fan_power = max_fan_power * (fan_ratio**index)
+    else
+      # psc fan
+      fan_power = max_fan_power * fan_ratio * (0.3 * fan_ratio + 0.7)


Different fan power equations

yzhou601 · 2024-11-15T19:49:12Z

HPXMLtoOpenStudio/resources/hvac.rb

@@ -4489,21 +4511,19 @@ def self.calc_ceer_from_eer(cooling_system)
  def self.set_fan_power_rated(hvac_system, use_eer_cop)
    hvac_ap = hvac_system.additional_properties

+    # Based on RESNET DX Modeling Appendix
+    psc_ducted_watts_per_cfm = 0.414 # W/cfm, PSC fan
+    psc_ductless_watts_per_cfm = 0.414 # W/cfm, PSC fan


So far as I can tell, psc_ductless_watts_per_cfm is not used for any case. Ductless minisplit is always var speed and defaulted to bpm fans. Room AC and PTHPs are outside the scope.

yzhou601 · 2024-11-15T19:49:46Z

HPXMLtoOpenStudio/resources/hvac.rb

@@ -5076,7 +5096,7 @@ def self.calculate_heat_pump_defrost_load_power_watts(heat_pump, unit_multiplier
    end
    # cooling capacity and airflow are already with unit multiplier, calculate the capacity w/o multiplier
    nominal_cooling_capacity = heat_pump.cooling_capacity / unit_multiplier
-    defrost_power_fraction = (max_heating_airflow / design_airflow)**3
+    defrost_power_fraction = calculate_fan_power_from_curve(1.0, max_heating_airflow / design_airflow, heat_pump)


This should call the calculate_fan_power_from_curve in the first place, so I captured it here.

…o resnet_heat_pump

…-HPXML into resnet_heat_pump

…o resnet_heat_pump

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

…-HPXML into resnet_heat_pump

…pumps and mini-splits.

…-HPXML into datapoint_extrapolation # Conflicts: # BuildResidentialHPXML/measure.xml # BuildResidentialHPXML/resources/version.txt

…anup and consolidation.

… temperatures.

… extrapolation. Didn't see any impact on runtime.

…nStudio-HPXML into datapoint_extrapolation

Datapoint extrapolation

…o resnet_heat_pump

…solve the capacity retention.

…o resnet_heat_pump

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

…ce data

…of additional code cleanup.

…o resnet_heat_pump # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml

shorowit · 2025-02-07T13:10:38Z

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

-      <sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature!=95 and h:CapacityDescription="minimum"]) &gt;= 1'>Expected 1 or more element(s) for xpath: PerformanceDataPoint[OutdoorTemperature!=95 and CapacityDescription="minimum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
-      <sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature!=95 and h:CapacityDescription="maximum"]) &gt;= 1'>Expected 1 or more element(s) for xpath: PerformanceDataPoint[OutdoorTemperature!=95 and CapacityDescription="maximum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
+      <sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature=82 and h:CapacityDescription="minimum"]) = 1'>Expected 1 element(s) for xpath: PerformanceDataPoint[OutdoorTemperature=82 and CapacityDescription="minimum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
+      <sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature=82 and h:CapacityDescription="nominal"]) = 1'>Expected 1 element(s) for xpath: PerformanceDataPoint[OutdoorTemperature=82 and CapacityDescription="nominal"]</sch:assert> <!-- See [PerformanceDataPoint] -->


There is no nominal/rated 82F datapoint, we can't require this. Let's plan to discuss. (If we update this, also need to update docs and changelog.)

shorowit · 2025-02-07T13:12:45Z

BuildResidentialHPXML/measure.rb

@@ -1584,7 +1584,7 @@ def arguments(model) # rubocop:disable Lint/UnusedMethodArgument

    arg = OpenStudio::Measure::OSArgument.makeStringArgument('hvac_perf_data_heating_outdoor_temperatures', false)
    arg.setDisplayName('HVAC Detailed Performance Data: Heating Outdoor Temperatures')
-    arg.setDescription('Outdoor temperatures of heating detailed performance data if available. Applies only to variable-speed air-source HVAC systems (central air conditioners, mini-split air conditioners, air-to-air heat pumps, and mini-split heat pumps). One of the outdoor temperatures must be 47 F. At least two performance data points are required using a comma-separated list.')
+    arg.setDescription('Outdoor temperatures of heating detailed performance data if available. Applies only to variable-speed air-source HVAC systems (central air conditioners, mini-split air conditioners, air-to-air heat pumps, and mini-split heat pumps). Outdoor temperatures must be 47F, 17F, and 5F (and one optional temperature less than 5F). At least two performance data points are required using a comma-separated list.')


Note to self: need to update all of these out-of-date descriptions ("At least two performance data points are required using a comma-separated list").

yzhou601 added 2 commits November 8, 2024 22:20

updated fan watts per cfm default, added fan model type

7e5af49

update measures

bee0df1

yzhou601 self-assigned this Nov 12, 2024

shorowit mentioned this pull request Nov 12, 2024

Update HP models per RESNET HVAC addendum #1871

Open

20 tasks

yzhou601 and others added 10 commits November 13, 2024 12:54

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

54e3ad7

…o resnet_heat_pump

fix tests, changed defrost fan power cubic calculation to follow the …

a7d4806

…same resnet updates, remove in.schedules.csv in test_hvac.rb

one more fix

b40b1e6

Latest results.

06c27af

revert measured w/cfm defaults, updated rated fan power default, docs…

2d1fb0c

…, etc.

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

22af55b

…-HPXML into resnet_heat_pump

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

554f49a

…o resnet_heat_pump

update_measures

bf5d323

temporarily reverted indoor sensibility change

ac9c0e1

Latest results.

c2c484d

yzhou601 commented Nov 15, 2024

View reviewed changes

yzhou601 and others added 10 commits November 25, 2024 13:34

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

f05a5bf

…o resnet_heat_pump

update measures

a322dc4

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

9c9d5be

…-HPXML into resnet_heat_pump

Latest results.

3cae1a8

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

f2f9135

…o resnet_heat_pump

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

1edbedd

…o resnet_heat_pump

Updated indoor sensitivity coefficients

7a5f48a

added temperature bounds for indoor sensitivity

abb9663

Latest results.

01c5315

Latest results.

c495f89

shorowit reviewed Dec 13, 2024

View reviewed changes

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml Outdated Show resolved Hide resolved

yzhou601 and others added 4 commits December 13, 2024 12:01

renamed fanmotortype, and started variable speed assumption update

f1e8a75

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

7ffcbff

…-HPXML into resnet_heat_pump

one more rename

ab5d5eb

Allows optional EER or EER2 inputs for central air conditioners/heat …

f0fe87e

…pumps and mini-splits.

shorowit and others added 20 commits January 16, 2025 11:30

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

ab23aaf

…-HPXML into datapoint_extrapolation # Conflicts: # BuildResidentialHPXML/measure.xml # BuildResidentialHPXML/resources/version.txt

Implement 50% RESNET rule for min cooling ODB extrapolation. Code cle…

2d40a2c

…anup and consolidation.

Bugfix and rename variables for clarity.

e698b9b

Latest results.

3f93237

Bugfix for situation where cooling input power is increasing at lower…

1dfc3c6

… temperatures.

Latest results.

00efee5

Using a more conservative min ODB temperature for cooling performance…

0ea97fd

… extrapolation. Didn't see any impact on runtime.

Merge branch 'datapoint_extrapolation' of https://github.com/NREL/Ope…

0f16d7c

…nStudio-HPXML into datapoint_extrapolation

Latest results.

259226a

Merge pull request #1904 from NREL/datapoint_extrapolation

b9e3429

Datapoint extrapolation

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

5d2d34e

…o resnet_heat_pump

update measures

706672c

implemented most default assumptions into OS-HPXML, still needs to re…

3f0b0e3

…solve the capacity retention.

fix a few issues to run test files

f191e0b

fix compressor type default using seer

5869e03

fix bugs in current capacity17F and retention

b65e5da

revert 17F requirement, first cut to model 3 speeds

d42a771

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

0b219eb

…o resnet_heat_pump

bugfixes

5329c9d

more fixes, update measures

a0e3b2f

shorowit reviewed Feb 5, 2025

View reviewed changes

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml Outdated Show resolved Hide resolved

yzhou601 and others added 7 commits February 5, 2025 17:09

fix pthp hspf calculation

8cd88d0

remove requirement of heating/cooling capacity for detailed performan…

5c17fcc

…ce data

oops, specified the wrong capacities

d4092db

Latest results.

af5e4fd

Update docs/changelog for where we are heading. [ci skip]

b2d5488

Rename data_array to datapoints_by_stage, convert to hash. And a bit …

6d92d56

…of additional code cleanup.

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

9a0de11

…o resnet_heat_pump # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml

shorowit reviewed Feb 7, 2025

View reviewed changes

shorowit mentioned this pull request Feb 7, 2025

Update NEEP ASHP sample files #1925

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update HVAC models per RESNET HVAC addendum #1879

Update HVAC models per RESNET HVAC addendum #1879

yzhou601 commented Nov 9, 2024

yzhou601 Nov 15, 2024

yzhou601 Nov 15, 2024

yzhou601 Nov 15, 2024

yzhou601 Nov 15, 2024

yzhou601 Nov 15, 2024

yzhou601 Nov 15, 2024

shorowit Feb 7, 2025

shorowit Feb 7, 2025

Update HVAC models per RESNET HVAC addendum #1879

Are you sure you want to change the base?

Update HVAC models per RESNET HVAC addendum #1879

Conversation

yzhou601 commented Nov 9, 2024

Pull Request Description

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment