Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datapoint extrapolation #1904

Merged
merged 40 commits into from
Jan 17, 2025
Merged

Datapoint extrapolation #1904

merged 40 commits into from
Jan 17, 2025

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Dec 26, 2024 •
edited
Loading

Pull Request Description

Addresses #1871. Updates datapoint extrapolation per RESNET MINHERS Addendum 82.

Breaking Change: Detailed performance datapoints must now use OutdoorTemperature values of:
- Heating: 47F, 17F, and 5F (plus an optional user-specified temperature <5F)
- Cooling: 82F and 95F (plus an optional user-specified temperature >95F)

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit
First pass.
3a1c29b
@shorowit
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
c36aa2f 
…-HPXML into datapoint_extrapolation

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/defaults.rb
#	HPXMLtoOpenStudio/tests/test_defaults.rb
#	docs/source/workflow_inputs.rst
@shorowit
Update Changelog.md
d1b6749
@shorowit shorowit added the enhancement New feature or request label Dec 26, 2024
@shorowit shorowit self-assigned this Dec 26, 2024
@shorowit
Update comment [ci skip]
8a55975
@shorowit
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
85effef 
…-HPXML into datapoint_extrapolation

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Add capacity & power datapoint checks.
80776d1
@shorowit
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
5a8c811 
…-HPXML into datapoint_extrapolation

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Simplify extrapolation bounds.
143b37e
@shorowit
Minor code cleanup.
11d271c
@shorowit
Perform extrapolation until values become negative.
3ea0043
@shorowit
Simplify implementation to remove step search [ci skip]
f865e5c
@shorowit
Restrict outdoor temperatures for detailed datapoints so we can apply…
b90c066 
… the RESNET MINHERS Addendum 82 extrapolation rules. [ci skip]
@shorowit
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
fc63ba3 
…-HPXML into datapoint_extrapolation

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Fixes some CI failures.
d01e7ff
@shorowit shorowit mentioned this pull request Jan 7, 2025
Open
20 tasks
shorowit
shorowit commented Jan 7, 2025
View reviewed changes
HPXMLtoOpenStudio/resources/hpxml.rb Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved
workflow/hpxml_inputs.json Show resolved Hide resolved
@shorowit
Copy link
Contributor Author

shorowit commented Jan 7, 2025

@yzhou601 This PR is ready, other than the one test failure:
base-hvac-air-to-air-heat-pump-var-speed-max-power-ratio-schedule-two-systems.xml: [Peak Load: Cooling: Delivered (kBtu/hr), Annual] 1x=228.96999999999997, 10x=195.301, abs_delta_tol=0.2, abs_frac_tol=0.05

@shorowit shorowit marked this pull request as ready for review January 7, 2025 20:53
@yzhou601
Copy link
Collaborator

@yzhou601 This PR is ready, other than the one test failure: base-hvac-air-to-air-heat-pump-var-speed-max-power-ratio-schedule-two-systems.xml: [Peak Load: Cooling: Delivered (kBtu/hr), Annual] 1x=228.96999999999997, 10x=195.301, abs_delta_tol=0.2, abs_frac_tol=0.05

Should be fixed in the last commit, let's give it a try and I'll review this PR after CI gets green.

@shorowit shorowit mentioned this pull request Jan 11, 2025
Merged
7 tasks
@shorowit
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
ba5a075 
…-HPXML into datapoint_extrapolation

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results_simulations_bills.csv
#	workflow/tests/base_results/results_simulations_energy.csv
#	workflow/tests/base_results/results_simulations_loads.csv
@shorowit
Small docs image improvement [ci skip]
5634c0a
yzhou601
yzhou601 reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@yzhou601 yzhou601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice work to add the RESNET approach and clean up some old variables. A few comments.

HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved
shorowit
shorowit commented Jan 15, 2025
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
shorowit and others added 10 commits January 15, 2025 14:43
@shorowit
Disallow 60F heating/cooling datapoints and address additional review…
03cd5f1 
… comments.
@shorowit
Forgot to commit these changes too
5848d90
@shorowit
Update test.
e3badf5
Latest results.
a803ed6
@shorowit
Double tolerance to reduce number of datapoints by 2x with minimal im…
bb1638b 
…pact on results.
@shorowit
Merge branch 'datapoint_extrapolation' of https://github.com/NREL/Ope…
2851dd1 
…nStudio-HPXML into datapoint_extrapolation

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
Latest results.
f2412b2
@shorowit
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
ab23aaf 
…-HPXML into datapoint_extrapolation

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	BuildResidentialHPXML/resources/version.txt
@shorowit
Implement 50% RESNET rule for min cooling ODB extrapolation. Code cle…
2d40a2c 
…anup and consolidation.
@shorowit
Bugfix and rename variables for clarity.
e698b9b
yzhou601
yzhou601 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@yzhou601 yzhou601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @shorowit for all the improvements here!

@shorowit shorowit merged commit b9e3429 into resnet_heat_pump Jan 17, 2025
@shorowit shorowit deleted the datapoint_extrapolation branch January 17, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhou601 yzhou601 yzhou601 approved these changes

Assignees

@shorowit shorowit

Labels
enhancement New feature or request
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shorowit @yzhou601