Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate schedules only for things that exist #1915

Open
wants to merge 22 commits into
base: ev_schedules
Choose a base branch
from

Conversation

rajeee
Copy link
Collaborator

@rajeee rajeee commented Jan 23, 2025

Pull Request Description

Currently, the schedule generator produces schedules for all stochastic schedules - even for enduses that don't exist in the building. That's unnecessary computation and storage and also a potential source of confusion. This PR modifies the generator to only generate schedules for things that exist.

More specifically, the following list of schedules will be generated only if the corresponding end use exist in the HPXML file.

  • dishwasher
  • hot_water_dishwasher
  • clothes_washer
  • hot_water_clothes_washer
  • clothes_dryer
  • cooking_range
  • ev_battery_charging
  • ev_battery_discharging
  • ev_occupant
  • lighting_garage (only if garage is present)
  • ceiling_fan
  • plug_loads_other
  • plug_loads_tv

The following schedules are always generated

  • occupants
  • lighting_interior
  • hot_water_fixtures

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Jan 25, 2025
@rajeee rajeee requested a review from shorowit January 29, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants