-
Notifications
You must be signed in to change notification settings - Fork 47
MPC TLDRD #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hdunham
wants to merge
3,097
commits into
develop
Choose a base branch
from
h2-tldrd-mpc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
MPC TLDRD #418
Changes from all commits
Commits
Show all changes
3097 commits
Select commit
Hold shift + click to select a range
ced7804
delete old commented out code
hdunham 499ed4e
set wind_kw_ac_time_series in backup_reliability_reopt_inputs
hdunham a186bee
correct _without_storage to _without_battery
hdunham 0ff719f
fix missed var name change
hdunham bb403a9
change PV to wind in backup_reliability_reopt_inputs.json
hdunham 5ee1bea
presave reopt result in erp test
hdunham b66a2c9
Update runtests.jl
hdunham 320afe9
uncomment tests
hdunham e640eea
Update CHANGELOG.md
hdunham 80c5acd
update backup_reliability docstrings with wind and corrections
hdunham bde9aef
condense some ERP tests PV and wind
hdunham 578232c
condense syntax
hdunham b3c91f4
Debug fuel cell hydrogen consumption output
lixiangk1 c725f0f
Debug fuel cell hydrogen consumption output
lixiangk1 18cef5e
Zero out more variables when techs aren't included
lixiangk1 c1374b1
Zero out more variables when techs aren't included
lixiangk1 6e1143c
Add Wind to stochastic outage results
Bill-Becker b8c9d6c
Update LICENSE per Angela Hupp email 2023.07.21
Bill-Becker d368be0
Update README with REopt registered trademark
Bill-Becker 7efe4df
Update REopt Copyright language for each file
Bill-Becker 115e2ce
add wind_production_factor_series to dictkeys_tosymbols
hdunham 5d65351
fix Wind series outputs being JuMP.Containers.DenseAxisArray instead …
hdunham 7151ae9
uncomment tests
hdunham 1d17ce0
correct batt efficiencies input names in docstrings
hdunham ba62b6c
Merge pull request #265 from NREL/license-update
Bill-Becker 078b49d
Merge branch 'develop' into outages-results
Bill-Becker 05255c8
update output name: fuel_survival_final_time_step
hdunham c77e268
Merge branch 'hydrogen' into h2-erp
indu-manogaran 96f7a01
Merge branch 'hydrogen' into h2-erp
indu-manogaran bf8d9ed
Merge branch 'develop' into hydrogen
indu-manogaran 8f746a6
Merge branch 'develop' into hydrogen
indu-manogaran fbc6710
Merge branch 'hydrogen' into h2-erp
indu-manogaran e3f762d
Merge branch 'hydrogen' into h2-erp
indu-manogaran c83a917
Add critical load and storage SOC series to outage results
Bill-Becker fa7de06
Make load balance for stochastic outages == instead of supply >= load
Bill-Becker ef29095
Add tests for outage load balance mod and results additions
Bill-Becker 9b5111c
Fix name issue in new test
Bill-Becker af925d7
Merge pull request #263 from NREL/wind-erp
hdunham 3e89032
Merge branch 'master' into develop
hdunham 0551823
Update Project.toml
hdunham a098439
Update CHANGELOG.md
hdunham 9c1baee
Merge branch 'develop' into erp-fixes
hdunham 5f27048
update H2 default efficiencies in ERP
hdunham 2cdeee6
update H2 default efficiencies in ERP
hdunham e142320
correct default in Electrolyzer docstring
hdunham e67fab9
correct default in Electrolyzer docstring
hdunham 85a42fd
update H2_operational_availability default
hdunham e2c0fc4
update H2_operational_availability default
hdunham de05ef0
add electric_storage_microgrid_upgraded to Outages outputs
hdunham efd0a7e
replace use of non-existent storage_upgraded with electric_storage_mi…
hdunham 47b2632
replace use of non-existent <tech>_upgraded in ERP
hdunham 8333b2d
use production_factor_series instead of summing dispatch series
hdunham 97a3ed9
correct calc of diesel gen size in backup_reliability_reopt_inputs
hdunham 37898b4
use ternary operator instead of if else to avoid scope issues
hdunham 2135a20
calc prime gen size in backup_reliability_reopt_inputs
hdunham bbd20a3
temp hack to handle multiple PV in results results in ERP
hdunham f63b922
temp hack to handle multiple PV in results results in ERP
hdunham 1cc38b5
convert some reopt outputs from denseaxisarray to vector
hdunham b0a8a89
get erp generator inputs from reopt results/inputs backup_reliability…
hdunham 54b34aa
don't production_factor_series instead of summing dispatch series
hdunham 2ea6472
Update CHANGELOG.md
hdunham c6b049b
Fix Wind outage docstring naming
Bill-Becker d24c2e2
Remove _n for outages, not multi-node compatible
Bill-Becker 9275b0d
Use p.storage.types.elec instead of ElectricStorage for indexing Stor…
Bill-Becker 6e3e85a
Make "no-storage" case have empty arrays for storage outage outputs
Bill-Becker abdf8b6
Change outage critical load series to same shape as other outage time…
Bill-Becker 5dbfb71
Update indexing in wind outage load test
Bill-Becker 23b2967
Merge branch 'develop' into outages-results
Bill-Becker c4e5535
Merge pull request #269 from NREL/erp-fixes
hdunham a037851
Merge branch 'develop' into outages-results
hdunham 9b9966e
Merge pull request #266 from NREL/outages-results
Bill-Becker fde4362
Update CHANGELOG.md
Bill-Becker 36f1005
Merge branch 'develop' into h2-erp
hdunham a0f7682
Merge branch 'develop' into h2-erp
hdunham 3453d8f
delete dupe tests
hdunham a343c40
delete dupe tests
hdunham 1dba5f2
fix system_characteristics prob calcs
hdunham 62166e9
fix system_characteristics prob calcs
hdunham 2a2b8a7
fix merge mistakes
hdunham 825c77c
fix merge mistakes
hdunham d6ec4ec
Debug load balance
indu-manogaran 1e04f6b
Debug load balance
indu-manogaran 71efc91
Add OM costs and update defaults
indu-manogaran 6eb1a70
Add OM costs and update defaults
indu-manogaran a27df05
Merge branch 'h2-erp' of https://github.com/NREL/REopt.jl into h2-erp
indu-manogaran d30bf83
Merge branch 'h2-erp' of https://github.com/NREL/REopt.jl into h2-erp
indu-manogaran eb2c559
Merge branch 'h2-erp' of https://github.com/NREL/REopt.jl into h2-erp
hdunham bbe572d
Merge branch 'h2-erp' of https://github.com/NREL/REopt.jl into h2-erp
hdunham 8f5e77c
Merge branch 'wind-erp' into h2-new
hdunham 7d05b89
merge dupe tests
hdunham ddc0e38
fix system_characteristics dict
hdunham 68e7a80
correct var names
hdunham 934016e
rerun and presave reopt in erp tests
hdunham c3dacc5
re-presave outagesim results in erp tests
hdunham ede4551
update presaved results for erp tests
hdunham 518ca96
use presaved results in erp tests
hdunham 088a6dd
simplify system_characteristics prob calcs
hdunham 9b47dc1
test system_characteristics simplification
hdunham 645ae5c
fix system_characteristics_probability
hdunham ba82bb0
Revert "test system_characteristics simplification"
hdunham daf6347
Merge branch 'develop' into h2-new
hdunham e9e6c25
Debug load balance
indu-manogaran c293b50
Add OM costs and update defaults
indu-manogaran 0da4d62
merge fix of temp hack to handle multiple PVs in ERP
hdunham 462e75c
Merge branch 'master' into develop
Bill-Becker 47c1da5
Merge branch 'develop' of https://github.com/NREL/REopt.jl into develop
Bill-Becker b7ae547
add storage leakage function to erp
hdunham de5caa2
test storage leakage function
hdunham b1658ca
move storage leakage to after all dispatch in ts
hdunham 2b715b1
pass through args for storage leakage rates
hdunham f583eb9
test erp run with leakage
hdunham 424d8d4
fix leage arg mistakes and missed docs
hdunham d09f463
Update runtests.jl
hdunham 2c4fb66
uncomment tests
hdunham ff01dcd
trigger tests
hdunham 6d4e09a
Update runtests.jl
hdunham 31473a3
rm unit test of storage_leakage now that in integration tests
hdunham 0c17bf2
update erp leakage defaults
hdunham 7411803
add missing tech tech sets to Techs(s::MPCScenario)
hdunham 1d55abf
restrict HiGHS version due to bug in 1.7
hdunham ef1b2a5
Revert "restrict HiGHS version due to bug in 1.7"
hdunham 7ffa743
Merge branch 'develop' into h2-new
hdunham 8115d6d
trigger tests
hdunham 246bb8f
Merge branch 'develop' into h2-new
lixiangk1 add952d
Add h2 leakage and battery self discharge
lixiangk1 b2903bf
Update hydrogen storage tank min soc
lixiangk1 c62c58f
Update LP storage results variable name
lixiangk1 52c9a9b
Merge branch 'develop' into h2-new
indu-manogaran c3faecc
Merge branch 'develop' into h2-tldrd-mpc
lixiangk1 6e0c7c6
Merge branch 'add-process-heat-load' into h2-tldrd-mpc
lixiangk1 4861d45
Hydrogen storage model
indu-manogaran 64af7ba
Initial implementation of electric heater and process heating load in…
lixiangk1 16de677
Hydrogen storage MPC model
indu-manogaran 7e2c07e
Distinguish between all techs and elec techs in mpc runs
lixiangk1 7555100
Add MPC fuel cell to elec techs
indu-manogaran b5f18ad
Add initial solid-state TES implementation
lixiangk1 900af9f
MPC results keys renaming
indu-manogaran a989188
Add separate charge vs discharge limits on HighTempThermalStorage in mpc
lixiangk1 38a33ae
Merge branch 'develop' into h2-tldrd-mpc
lixiangk1 53cd29e
Add Wind to MPC
lixiangk1 d26ba78
Merge branch 'h2-erp' of https://github.com/NREL/REopt.jl into h2-erp
indu-manogaran eca4526
Merge branch 'develop' into h2-erp
indu-manogaran e08044c
Syntax error correction
indu-manogaran 97b8eb8
Add hydrogen to multiple outages
lixiangk1 1fe4d5e
Initial off-grid implementation for mpc (no h2)
lixiangk1 15b2c50
Hydrogen model updates
indu-manogaran b78be8a
Merge branch 'develop' into h2-erp
indu-manogaran 1b01a63
Add heuristics BESS dispatch, correct mpc battery efficiency defaults
lixiangk1 0757902
Merge branch 'develop' into h2-erp
hdunham 7366b59
remove xpress docker files
hdunham 54c8eb1
small code simplification
hdunham c67aae1
Hydrogen model updates multiple updates
indu-manogaran 0877cdc
Merge branch 'develop' into h2-tldrd-mpc
hdunham a6f7f9e
syntax consistency
hdunham 4b68fdb
confirm techs not nothing before accessing fields
hdunham 689c861
correct Tech struct docstring
hdunham 0fd049b
eliminate unnecessary steps
hdunham 31b027a
conciseness
hdunham 408275b
add override warning
hdunham be75a33
if else clarity
hdunham a457e34
uodate add_electric_load_results docstring
hdunham f0d9491
add critical_load_series_kw to MPC outputs
hdunham 6c2a13a
MPC: add emissions accounting and CO2 cost to objective function
lixiangk1 31a0ee2
Merge branch 'h2-tldrd-mpc' of https://github.com/NREL/REopt.jl into …
lixiangk1 bdbc423
rm dupe if condition
hdunham bec41fe
add clarity to emissions warning msg
hdunham 228b2ed
tie grid_charge_efficiency default to charge_efficiency
hdunham c4c5f0d
add docstrings
hdunham 82eccb8
add to add_hot_storage_results docstring
hdunham e63a83d
Hydrogen model debug
indu-manogaran d1eaaad
Merge branch 'h2-erp' into h2-tldrd-mpc
indu-manogaran 6174dfd
Bug fix
indu-manogaran 14fd1f0
Allow init soc to be read for MPCElectricStorage
lixiangk1 65dcdd6
Add time series intermediary emissions variables for MPC
lixiangk1 48424e1
Hydrogen model update
indu-manogaran cec4cca
Merge branch 'h2-erp' into h2-tldrd-mpc
indu-manogaran 3e4f8b1
Change sum operator to expression emissions
indu-manogaran cde2917
Change sum operator to expression emissions
indu-manogaran 13ede1e
RE accounting hydrogen
indu-manogaran 04ed96e
Merge branch 'develop' into h2-tldrd-mpc
lixiangk1 c86a7c5
Hydrogen model debug
indu-manogaran cfc164a
Merge branch 'develop' into h2-erp
hdunham cafea0f
merge changes to testset Backup Generator Reliability
hdunham 6468462
rm dupe test using for ref in merge
hdunham fa42f96
Debug tests - update RE calculations and multinode variable declaration
lixiangk1 be4b8a0
Update check for h2 techs in RE calc
lixiangk1 2bb93ec
Debug multinode and mpc tests
lixiangk1 e7b0e7c
Debug emissions and simultaneous import export tests
lixiangk1 b299673
Revert "Debug emissions and simultaneous import export tests"
lixiangk1 8ea65ea
add Logging to test Project
hdunham 036d516
Hydrogen bug fixes
lixiangk1 21b5ed2
Update storage constraints to enable require_start_and_end_charge_to_…
lixiangk1 31d1646
Merge remote-tracking branch 'origin/h2-tldrd-mpc' into merge-h2-bran…
zolanaj f230faf
Merge branch 'develop' into merge-h2-branches
zolanaj 73bcfe4
fix syntax from merge conflicts
zolanaj 90d87b5
reintroduce backup reliability with H2 tests
zolanaj 5bc54bb
reconcile storage sum, storage sum grid constraints
zolanaj 38865db
add storage to indices of dvMGProductionToStorage
zolanaj d51b18e
rm duplicate MPC test
zolanaj 837aa54
rm dvMGProductionToStorage from outage results when no electric stora…
zolanaj c11df64
MPC hydrogen model updates
indu-manogaran 5107101
MPC hydrogen model updates
indu-manogaran fe196a8
Merge remote-tracking branch 'origin/h2-tldrd-mpc' into merge-h2-bran…
zolanaj 57c2b4a
temporarily suppress outage constraints
zolanaj e7f5610
Merge branch 'develop' into merge-h2-branches
zolanaj 0e9597e
fix syntax in MPC from merge conflict resolution
zolanaj fdbb45f
make default critical_load_fraction zero for hydrogen
zolanaj edfe260
return vectors of zeros for yr1 emissions if !(p.s.site.include_expor…
zolanaj a17bc63
uncomment previous tests
zolanaj 3fe0461
Add HighTempThermalStorage
lixiangk1 b53ce62
Merge remote-tracking branch 'origin/h2-tldrd-mpc' into merge-h2-bran…
zolanaj 96ed90d
HighTempThermalStorage - add optional constraints for constraining di…
lixiangk1 6068d6a
only add storage sum grid constraints when storage is present
zolanaj 9a30170
check for high temp storage before building specific high-temp constr…
zolanaj 671bbc3
add ElectricUtility to MPC docs
hdunham 705784d
rename input tou_demand_time_steps for consistency
hdunham 7123778
Update CHANGELOG.md
zolanaj 42c6c4e
pass thru some missing MPC ElectricUtility inputs
hdunham 735d245
(part 2) rename input tou_demand_time_steps for consistency
hdunham 0cf5c4b
Update documentation for hydrogen and MPC techs
lixiangk1 b583386
add todo
hdunham 4ddfb52
add electric_to_electrolyer when calculating pv, wind output in backu…
zolanaj 3c89e5b
transpose markov matrix and correct example probability in docs
zolanaj 0a68271
comments
hdunham 60e3103
error typo
hdunham a2453de
rename function for specificity
hdunham bc4f668
carry transposition into matrix operations (probability array is a ro…
zolanaj cc8270b
docstrings for survival_with_storage_single_start_time
zolanaj f0e811f
Merge branch 'h2-tldrd-mpc' into merge-h2-branches
zolanaj 1e0f78f
Merge branch 'h2-erp' into merge-h2-branches
zolanaj 3e08948
Merge branch 'h2-tldrd-mpc' of https://github.com/NREL/REopt.jl into …
hdunham a5dcf25
Update electric, thermal, and h2 storage self-discharge modeling
lixiangk1 c8f9d33
additional notes on probability matrix update
zolanaj 2d0aa19
addditional notes on survival_with_storage_single_start_time
zolanaj 6841bf0
transpose matrices in gen_only_survival_single_start_time
zolanaj a3cc4f6
flatten probability array for states and add notes on order
zolanaj c906df3
fix starting state calculation
zolanaj 689420d
translate probability vector to match 3D array for storage shifts
zolanaj 63840b4
update license reference to single line for new files
zolanaj fcedba0
suppress print statement
zolanaj a9b7095
Add hydrogen load results in MPC outputs when compressor is not selected
lixiangk1 116ef37
Merge branch 'h2-tldrd-mpc' of https://github.com/NREL/REopt.jl into …
hdunham fbcfcd4
update self discharge docs descriptions
hdunham ed68a84
readability
hdunham 8c3b8e6
update thermal stor docstrings
hdunham 55a5fb9
align thermal stor field names
hdunham 09d2c47
align outage_constraints w/ new self-discharge model
hdunham 2964281
Update MPC documentation
lixiangk1 69b8a20
revert all changes in backup_reliability.jl
hdunham a8b92b1
Add H2 tests
lixiangk1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems unnecessary for dvGridToStorage, dvGridToElectrolyzer, and dvGridToCompressor to be added here since they already have to be <= dvGridPurchase