Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile total site load #456

Open
wants to merge 32 commits into
base: gridRE-dev
Choose a base branch
from
Open

Conversation

zolanaj
Copy link
Collaborator

@zolanaj zolanaj commented Nov 26, 2024

Added

  • New result ElectricLoad.annual_electric_load_with_thermal_conversions_kwh which calculates end-use electrical load after including electric consumption by heaters and chillers

Fixed

  • Updated the expression m[:AnnualEleckWh] to include electrified thermal loads
  • Updated expressions m[AnnualREHeatkWh] and AnnualHeatkWh so that only non-electrified thermal loads are included and storage losses are proportional to the contribution of fuel-burning technologies to charging storage

@zolanaj
Copy link
Collaborator Author

zolanaj commented Nov 26, 2024

@adfarth just tracking a couple other notes here:

  • This causes a few test to fail, which we can update after confirming the other tests are passing and none are erroring out (other than a possible PVWatts timeout)
  • This does not match the current results value ElectricLoad.annual_calculated_kwh which only includes site load
  • The renewable energy fraction for combined thermal and electrical shouldn't use this expression plus the thermal load or it will double count. Maybe that one uses the site loads?

No fixes for these yet but I'll track and see if I can follow up with good fixes. One concern is the electrical load could be a weird

@zolanaj zolanaj changed the title Do not merge yet: Reconcile total site load Reconcile total site load Jan 30, 2025
@zolanaj zolanaj requested a review from adfarth January 30, 2025 03:36
@zolanaj
Copy link
Collaborator Author

zolanaj commented Jan 30, 2025

@adfarth Ready for you to check! The steam turbine is left out of all of this for now but the other heating and cooling loads have been caught up. I added a result in Site to track converted thermal to electrical load (it's only used in testing but seems like a reasonable thing to track for electrification studies in general).

@adfarth
Copy link
Collaborator

adfarth commented Feb 6, 2025

@zolanaj would you mind adding a CHANGELOG entry for this? And perhaps updating the PR description with the same entry?

src/results/site.jl Outdated Show resolved Hide resolved
src/results/site.jl Outdated Show resolved Hide resolved
src/results/site.jl Outdated Show resolved Hide resolved
src/results/site.jl Outdated Show resolved Hide resolved
@zolanaj
Copy link
Collaborator Author

zolanaj commented Feb 11, 2025

@zolanaj would you mind adding a CHANGELOG entry for this? And perhaps updating the PR description with the same entry?

updated here and ready for another review.

src/results/site.jl Outdated Show resolved Hide resolved
- `offgrid_load_met_fraction` percentage of total electric load met on an annual basis, for off-grid scenarios only
- `offgrid_annual_oper_res_required_series_kwh` , total operating reserves required (for load and techs) on an annual basis, for off-grid scenarios only
- `offgrid_annual_oper_res_provided_series_kwh` , total operating reserves provided on an annual basis, for off-grid scenarios only
- `load_series_kw` # vector of BAU site load in every time step. Does not include electric load for any new heating or cooling techs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zolanaj I added these descriptions. If you have a second to review that is welcome!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, thank you @adfarth! I'll merge the PR once tests are confirmed to pass.

Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as long as these latest tests pass -- thank you, Alex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants