Skip to content

Fix boiler emissions #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adfarth merged 3 commits into from
Jan 6, 2026
Merged

Fix boiler emissions #565

adfarth merged 3 commits into from
Jan 6, 2026

Conversation

@adfarth
Copy link
Collaborator

@adfarth adfarth commented Jan 2, 2026

p.tech_emissions_factors_XXX["Boiler"] were previously 0 because these values were not getting updated in setup_boiler_inputs(). This PR fixes this.

@zolanaj zolanaj self-requested a review January 5, 2026 15:59
zolanaj
zolanaj approved these changes Jan 5, 2026
View reviewed changes
Copy link
Collaborator

@zolanaj zolanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @adfarth! I added a test to ensure it's working as intended and it passed locally. Assuming it passes on actions and you agree with the test, this can be merged.

@adfarth adfarth merged commit 0a62c15 into develop Jan 6, 2026
3 checks passed
@adfarth adfarth deleted the boiler-emissions branch January 6, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zolanaj zolanaj zolanaj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adfarth @zolanaj