Up numpy requirement to numpy~=2.0 #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
added
on-hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following FLORIS, which is a dependency of WHOC, this PR ups the
numpydependency to numpy version 2.It may also be necessary to also update the FLORIS requirement to
floris~=4.3. I will test that once the FLORIS PR is merged and FLORIS v4.3 (containing FLORIS'snumpy~=2.0requirement) is released. Until that time, this PR should remain a draft and should not be merged.I have checked locally that tests and examples run, so I don't expect any issues with moving up to numpy v2 once the FLORIS update is merged.
I have opened a sister PR on Hercules.