Open
Conversation
reeesadh
reviewed
Mar 21, 2025
Contributor
There was a problem hiding this comment.
Ground intake motor is now 12, took the algae arm id for this
paulwdavis
reviewed
Mar 21, 2025
| public GroundIntake() {} | ||
|
|
||
| /** Sets the goal velocity in meters per second. */ | ||
| public void setGoalVelocity(double velocity) { |
Contributor
There was a problem hiding this comment.
Question: for simply "holding" a coral piece that has been acquired, do we want something other than velocity control? I.e. when the motor is stalled in "hold mode", does the PID controller ramp up the motor power trying to reach the given velocity?
paulwdavis
reviewed
Mar 21, 2025
| laserCAN.setRangingMode(LaserCan.RangingMode.SHORT); | ||
| laserCAN.setRegionOfInterest( | ||
| new LaserCan.RegionOfInterest(12, 8, 8, 16)); // Makes detection region a box | ||
| new LaserCan.RegionOfInterest(7, 8, 2, 16)); // Makes detection region a box |
Contributor
There was a problem hiding this comment.
ROI width and height is apparently limited to a minimum of 4 SPADs according to the spec sheet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.