Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts ColorConstant values to an enum #85

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

edreed
Copy link
Contributor

@edreed edreed commented Feb 8, 2025

This change converts the values in ColorConstants to an enum which allows for better logging of color commands. It also limits the color commands to the actual subsystem LED subsegment length rather than assuming the subsystem owns the full count.

@edreed edreed requested a review from Copilot February 8, 2025 06:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • src/main/java/frc/robot/util/LEDSegment.java: Evaluated as low risk
  • src/main/java/frc/robot/commands/DriveCommands.java: Evaluated as low risk
  • src/main/java/frc/robot/Constants.java: Evaluated as low risk
  • src/main/java/frc/robot/commands/RainbowCycle.java: Evaluated as low risk
  • src/main/java/frc/robot/subsystems/StatusLED.java: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/main/java/frc/robot/parameters/Colors.java:23

  • The color name LIGHT_BLUE is inconsistent with the previous naming convention LIGHTBLUE. It should be renamed to LIGHTBLUE for consistency.
LIGHT_BLUE(56, 197, 252);
@edreed edreed force-pushed the edreed/color-enum branch from baf1a41 to e1a3141 Compare February 8, 2025 06:50
@edreed edreed merged commit 2e0c39f into NRG948:main Feb 8, 2025
@edreed edreed deleted the edreed/color-enum branch February 8, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant