Skip to content

Commit

Permalink
Refactor get_commissioning_proposals endpoint to enhance documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
stuartcampbell committed Feb 11, 2025
1 parent 053f7d3 commit 7fe8b62
Showing 1 changed file with 20 additions and 2 deletions.
22 changes: 20 additions & 2 deletions src/nsls2api/api/v1/proposal_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,27 @@ async def get_recent_proposals(count: int, beamline: str | None = None):


@router.get("/proposals/commissioning", response_model=CommissioningProposalsList)
async def get_commissioning_proposals(beamline: str | None = None, facility: FacilityName | None = None):
async def get_commissioning_proposals(
beamline: str | None = None, facility: FacilityName | None = None
):
"""
Get a list of commissioning proposals. If a beamline is provided, only proposals
for that beamline will be returned and the facility will be ignored.
Args:
beamline (str optional): The beamline to filter proposals by.
facility (FacilityName optional): The facility to filter proposals by.
Returns:
CommissioningProposalsList: A list of commissioning proposals.
Raises:
HTTPException: If no commissioning proposals are found or an error occurs.
"""
try:
proposals = await proposal_service.commissioning_proposals(beamline=beamline, facility=facility)
proposals = await proposal_service.commissioning_proposals(
beamline=beamline, facility=facility
)
if proposals is None:
raise HTTPException(
status_code=fastapi.status.HTTP_404_NOT_FOUND,
Expand Down

0 comments on commit 7fe8b62

Please sign in to comment.