Initial set of CI tests together with a ephemeral MongoDB container #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want to add a development mode, it should be added in the config::get_settings() method (similar to where we are checking for running under pytest)
padraic-shafer
approved these changes
Oct 25, 2024
Comment on lines
+32
to
+33
| # This is to make sure that the client is using the same event loop as the rest of the application | ||
| client.get_io_loop = asyncio.get_event_loop |
There was a problem hiding this comment.
Nice! I think this was defeating me in some rounds of debugging earlier.
| ) as ac: | ||
| response = await ac.get("/v1/beamline/does-not-exist") | ||
| assert response.status_code == 404 | ||
| assert response.json() == {"detail": "Beamline 'does-not-exist' does not exist"} |
There was a problem hiding this comment.
Depending on how strictly this response will be relied upon downstream--i.e., is this part of the API ?--consider a partial match here. E.g., 'does-not-exist' in response.text
Suggested change
| assert response.json() == {"detail": "Beamline 'does-not-exist' does not exist"} | |
| assert response.json() == {"detail": "Beamline 'does-not-exist' does not exist"} |
There was a problem hiding this comment.
I presume that you meant to enter a suggestion here and not the same code again 😄
Co-authored-by: Padraic Shafer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add some CI testing - it is not an exhaustive list, just submitting the PR before it gets really long!
The last run of the CI pipeline against this branch can be found here : https://github.com/stuartcampbell/nsls2api/actions/runs/11523289207
or in the test list below 😄