[do not merge] add opt-in NUMA binding for ci testing#4630
Draft
cuichenx wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Chen Cui <chcui@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds opt-in GPU-local NUMA binding for Kubeflow jobs launched through
torchrun.NCCL 2.30 restores the launcher's original CPU affinity after communicator initialization. Kubeflow training jobs currently launch ranks without an explicit CPU or memory binding, which can expose cross-NUMA host scheduling overhead for TP+EP MoE workloads such as Moonlight.
When
NEMO_KUBEFLOW_NUMA_BINDING=1is set, each torchrun worker now:LOCAL_RANKto its GPU PCI bus ID;numactl --cpunodebindand--membind.The implementation wraps the
run.Scripttask before it is passed to the stock NeMo-RunKubeflowExecutorandTorchrun. The default Kubeflow launcher path and exact executor class are unchanged.Changelog
GitHub Actions CI
Validation performed:
uv run --no-project --with pytest --with 'nemo-run==0.10.0' python -m pytest --confcutdir=tests/unit_tests/scripts/performance tests/unit_tests/scripts/performance/test_executors.py -q— 4 passed.kubeflow+torchrun, and generated/nemo_run/scripts/moonlight.shcontains the NUMA wrapper.uv run --no-project --with pre-commit pre-commit run --all-files— passed.uv sync --group devcannot complete on the local glibc 2.31 host because pinnednvidia-resiliency-ext==0.6.0provides glibc 2.39 wheels. The checks above were therefore run in isolated uv environments with the pinned NeMo-Run version.The first runtime attempt, job 353648344, exposed that subclassing
KubeflowExecutoris incompatible with NeMo-Run's exact-class executor mapping. It failed before TrainJob creation withKeyError: <class 'utils.executors._TransformingKubeflowExecutor'>; the implementation was then changed to the stock-executor task wrapper above.Corrected runtime validation is queued as NeMo-CI job 353773441 using
nvcr.io/nvidian/nemo:26.06.01.rc0on 64 GCP GB200 GPUs. Its owned GPULease is waiting for capacity with a 24-hour acquisition window. No TrainJob or W&B run exists yet, so live NUMA mapping and performance validation remain pending.Before your PR is "Ready for review"
Pre checks:
Additional Information
This draft targets
r0.5.0because the runtime experiment uses the 26.06.01 release stack and the change is based directly on release commit78540b21.