Skip to content

Guard nvrx __version__ + degrade async support gracefully for older nvidia-resiliency-ext #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yeyu-nvidia wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Draft

Guard nvrx __version__ + degrade async support gracefully for older nvidia-resiliency-ext #5605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions megatron/core/dist_checkpointing/strategies/nvrx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,8 @@ def has_nvrx_async_support() -> bool:
getattr(state_dict_saver, "save_state_dict_async_finalize", None),
getattr(state_dict_saver, "save_state_dict_async_plan", None),
)
assert (
is_nvrx_min_version()
), f"Minimum required nvidia-resiliency-ext package version is {NVRX_MIN_VERSION}."
if not is_nvrx_min_version():
return False

return all(symbol is not None for symbol in required_symbols) and hasattr(
filesystem_async, "_results_queue"
Expand Down Expand Up @@ -82,6 +81,6 @@ def is_nvrx_min_version(version: str = NVRX_MIN_VERSION) -> bool:
except (ImportError, ModuleNotFoundError):
HAVE_NVRX = False

nvrx_version = str(nvrx.__version__) if HAVE_NVRX else "0.0.0"
nvrx_version = str(getattr(nvrx, "__version__", "0.0.0")) if HAVE_NVRX else "0.0.0"

return PkgVersion(nvrx_version) >= PkgVersion(version)
Loading