feat: device platform connector#1198
Conversation
Signed-off-by: Dan Huenecke <dhuenecke@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🌿 Fern Docs Preview: https://nvidia-preview-pull-request-1198.docs.buildwithfern.com/nvsentinel |
| "event_count", count, | ||
| "version", healthEvents.GetVersion(), | ||
| } | ||
| if count > 0 { |
There was a problem hiding this comment.
I'm not sure if we'd need this, we can just log the complete health event array right?
There was a problem hiding this comment.
I went with the window logic to keep logs concise and searchable. Would you prefer I just log the raw array, or perhaps just a count/version to keep it minimal?
There was a problem hiding this comment.
I would just do the counts as info and the array as debug
| } | ||
|
|
||
| // nolint:cyclop,gocognit // Pipeline for sorting, deduplicating, and mapping events | ||
| func (r *DeviceConnector) processGPUEvents(ctx context.Context, name string, events []*pb.HealthEvent) error { |
There was a problem hiding this comment.
the logic here seems fairly similar to what we have in the kubernetes connector, can we reuse some of the existing functions?
2 participants
Summary
Type of Change
Component(s) Affected
Testing
Checklist