chore(dev): use ruff as linter and formatter #991
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if not import_path.endswith(".co") and os.path.exists( | ||
| os.path.join(root, import_path + ".co") | ||
| ): | ||
| if not import_path.endswith(".co") and os.path.exists(os.path.join(root, import_path + ".co")): |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 days ago
To fix the problem, we need to ensure that the constructed file paths are validated and contained within a safe root directory. This can be achieved by normalizing the path using os.path.normpath and then checking that the normalized path starts with the root directory. This approach will prevent directory traversal attacks by ensuring that the resolved path does not escape the intended directory.
- Normalize the
import_pathusingos.path.normpath. - Check that the normalized path starts with one of the allowed root directories in
colang_path_dirs. - If the path is valid, proceed with the file operations; otherwise, raise an exception.
Suggested changeset
1
nemoguardrails/rails/llm/config.py
| @@ -730,12 +730,17 @@ | ||
| actual_path = None | ||
| if not os.path.exists(import_path): | ||
| for root in colang_path_dirs: | ||
| if os.path.exists(os.path.join(root, import_path)): | ||
| actual_path = os.path.join(root, import_path) | ||
| break | ||
| normalized_import_path = os.path.normpath(import_path) | ||
| for root in colang_path_dirs: | ||
| normalized_root = os.path.normpath(root) | ||
| potential_path = os.path.join(normalized_root, normalized_import_path) | ||
| if os.path.commonprefix([potential_path, normalized_root]) != normalized_root: | ||
| continue | ||
| if os.path.exists(potential_path): | ||
| actual_path = potential_path | ||
| break | ||
|
|
||
| # We also check if we can load it as a file. | ||
| if not import_path.endswith(".co") and os.path.exists(os.path.join(root, import_path + ".co")): | ||
| actual_path = os.path.join(root, import_path + ".co") | ||
| break | ||
| # We also check if we can load it as a file. | ||
| potential_path_with_ext = potential_path + ".co" | ||
| if not import_path.endswith(".co") and os.path.exists(potential_path_with_ext): | ||
| actual_path = potential_path_with_ext | ||
| break | ||
| else: |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.