Nitpicky items in the docs #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike McKiernan <[email protected]>
mikemckiernan
requested review from
ArangoGutierrez,
shivamerla and
visheshtanksale
as code owners
mikemckiernan
commented
Aug 2, 2024
shivamerla
reviewed
Aug 2, 2024
I tried to imitate the phrasing I found when I accessed the following address in an incognito window: https://catalog.ngc.nvidia.com/orgs/nim/teams/meta/containers/llama-3.1-8b-instruct/tags This is the text: This page requires an active subscription to an NVIDIA AI Enterprise product Because the repository has a developer audience, I included the address for signing up. Signed-off-by: Mike McKiernan <[email protected]>
shivamerla
pushed a commit
that referenced
this pull request
Aug 5, 2024
* Nitpicky items in the docs Signed-off-by: Mike McKiernan <[email protected]> * Clarify registry reqs I tried to imitate the phrasing I found when I accessed the following address in an incognito window: https://catalog.ngc.nvidia.com/orgs/nim/teams/meta/containers/llama-3.1-8b-instruct/tags This is the text: This page requires an active subscription to an NVIDIA AI Enterprise product Because the repository has a developer audience, I included the address for signing up. Signed-off-by: Mike McKiernan <[email protected]> --------- Signed-off-by: Mike McKiernan <[email protected]>
shivamerla
pushed a commit
that referenced
this pull request
Aug 5, 2024
* Nitpicky items in the docs Signed-off-by: Mike McKiernan <[email protected]> * Clarify registry reqs I tried to imitate the phrasing I found when I accessed the following address in an incognito window: https://catalog.ngc.nvidia.com/orgs/nim/teams/meta/containers/llama-3.1-8b-instruct/tags This is the text: This page requires an active subscription to an NVIDIA AI Enterprise product Because the repository has a developer audience, I included the address for signing up. Signed-off-by: Mike McKiernan <[email protected]> --------- Signed-off-by: Mike McKiernan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.