Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify NeMoDataStore #286

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Modify NeMoDataStore #286

merged 4 commits into from
Jan 27, 2025

Conversation

shengnuo
Copy link
Collaborator

@shengnuo shengnuo commented Jan 16, 2025 •
edited
Loading

New API for supporting DataStore V2

Sample CR can be found at config/samples/apps_v1alpha1_nimdatastorev2.yaml

pre-requisite components:

  • Minio
  • Postgres

Secrets as specified in .spec.dataStoreParams that need to be created before deploying DataStore microservice

  • datastoreConfigSecret
  • datastoreInitSecret
  • datastoreInlineConfigSecret
  • extDBSetting.databaseSecret
  • giteaAdminSecret
  • lfsJwtSecret
  • objectStoreSetting.objectStoreSecret

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shengnuo shengnuo changed the title Support DataStore V2 Draft: Support DataStore V2 Jan 16, 2025
slu2011
slu2011 previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@slu2011 slu2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shengnuo shengnuo force-pushed the dsv2 branch 4 times, most recently from 2635757 to 735cdd7 Compare January 18, 2025 23:42
@shengnuo shengnuo force-pushed the dsv2 branch 4 times, most recently from 37ed08c to adfeb38 Compare January 22, 2025 23:09
@shengnuo shengnuo changed the title Draft: Support DataStore V2 Draft: Modify NeMoDataStore Jan 22, 2025
@shengnuo shengnuo changed the title Draft: Modify NeMoDataStore Modify NeMoDataStore Jan 23, 2025
varunrsekar
varunrsekar reviewed Jan 23, 2025
View reviewed changes
api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved
api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved
api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved
slu2011 and others added 3 commits January 24, 2025 11:13
visheshtanksale
visheshtanksale reviewed Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@visheshtanksale visheshtanksale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved
api/apps/v1alpha1/nemo_datastore_types.go Show resolved Hide resolved
api/apps/v1alpha1/nemo_datastore_types.go Show resolved Hide resolved
api/apps/v1alpha1/nemo_datastore_types.go Show resolved Hide resolved
visheshtanksale
visheshtanksale approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@visheshtanksale visheshtanksale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shivamerla
shivamerla approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@shivamerla shivamerla merged commit 329298c into NVIDIA:main Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunrsekar varunrsekar varunrsekar left review comments

@visheshtanksale visheshtanksale visheshtanksale approved these changes

@shivamerla shivamerla shivamerla approved these changes

@slu2011 slu2011 slu2011 left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shengnuo @slu2011 @varunrsekar @visheshtanksale @shivamerla