Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Entitystore] Use updater to set status conditions #289

Merged
merged 1 commit into from
Jan 18, 2025
Merged

[Entitystore] Use updater to set status conditions #289

merged 1 commit into from
Jan 18, 2025

Conversation

varunrsekar
Copy link
Collaborator

Set Entitystore CR status conditions using the updater.

Sample status condition:

status:
  conditions:
  - lastTransitionTime: "2025-01-17T23:24:01Z"
    message: ""
    reason: Failed
    status: "False"
    type: Ready
  - lastTransitionTime: "2025-01-17T23:24:01Z"
    message: '`spec.entityStoreParams.dbSecret` cannot be empty'
    reason: ValidationFailed
    status: "True"
    type: Failed
  state: Failed

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

shivamerla
shivamerla previously approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamerla shivamerla enabled auto-merge (squash) January 18, 2025 02:47
@shivamerla shivamerla self-requested a review January 18, 2025 02:48
@shivamerla shivamerla merged commit 850b403 into NVIDIA:main Jan 18, 2025
9 checks passed
@varunrsekar varunrsekar deleted the es-bugfixes branch January 21, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamerla shivamerla shivamerla approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@slu2011 slu2011 Awaiting requested review from slu2011 slu2011 is a code owner

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale visheshtanksale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunrsekar @shivamerla