Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nemo entitystore E2E test #304

Merged
merged 1 commit into from
Jan 31, 2025
Merged

add nemo entitystore E2E test #304

merged 1 commit into from
Jan 31, 2025

Conversation

varunrsekar
Copy link
Collaborator

Additional env flags needed to run E2E:

  • ENABLE_NEMO_MICROSERVICES - optionally run the nemo microservice CR tests
  • NEMO_ENTITYSTORE_REPO - image repo for nemo entity-store
  • NEMO_ENTITY_STORE_VERSION - image tag for nemo entity-store

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@varunrsekar varunrsekar force-pushed the es-e2e-tests branch 2 times, most recently from 486428f to 7468252 Compare January 30, 2025 18:48
shivamerla
shivamerla approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@varunrsekar @shivamerla
add nemo entitystore E2E test
8b95a4e 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@shivamerla shivamerla merged commit 96e10a7 into NVIDIA:main Jan 31, 2025
9 checks passed
@varunrsekar varunrsekar deleted the es-e2e-tests branch January 31, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamerla shivamerla shivamerla approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@slu2011 slu2011 Awaiting requested review from slu2011 slu2011 is a code owner

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale visheshtanksale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunrsekar @shivamerla